Skip to content

Potential fixes for 2 code quality findings #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ahosgood wants to merge 2 commits into from
Closed

Potential fixes for 2 code quality findings #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
755563f
Apply suggested fix to tna_utilities/url.py from Copilot Autofix
ahosgood Jan 2, 2026
c4bdd93
Apply suggested fix to tna_utilities/url.py from Copilot Autofix
ahosgood Jan 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions tna_utilities/url.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,13 @@ def parameter_exists(self, parameter) -> bool:
def parameter_values(self, parameter: str) -> list:
"""
Get the values associated with a parameter in the query parameters.
Raises an AttributeError if the parameter does not exist.
Raises a KeyError if the parameter does not exist.
"""

for key, values in self.args:
if key == parameter:
return values
raise AttributeError(f"Parameter '{parameter}' does not exist")
raise KeyError(f"Parameter '{parameter}' does not exist")

def add_parameter(
self, parameter: str, values: str | int | list | None = None
Expand Down Expand Up @@ -87,7 +87,7 @@ def remove_parameter(self, parameter: str) -> "QueryStringTransformer":
if key == parameter:
self.args.remove((key, vals))
return self
raise AttributeError(f"Parameter '{parameter}' does not exist")
raise KeyError(f"Parameter '{parameter}' does not exist")

def is_value_in_parameter(self, parameter: str, value: str | int) -> bool:
"""
Expand All @@ -98,7 +98,7 @@ def is_value_in_parameter(self, parameter: str, value: str | int) -> bool:
for key, values in self.args:
if key == parameter:
return str(value) in values
raise AttributeError(f"Parameter '{parameter}' does not exist")
raise KeyError(f"Parameter '{parameter}' does not exist")

def add_parameter_value(
self, parameter: str, value: str | int
Expand All @@ -113,7 +113,7 @@ def add_parameter_value(
if str(value) not in values:
values.append(str(value))
return self
raise AttributeError(f"Parameter '{parameter}' does not exist")
raise KeyError(f"Parameter '{parameter}' does not exist")

def toggle_parameter_value(
self, parameter: str, value: str | int
Expand All @@ -131,7 +131,7 @@ def toggle_parameter_value(
else:
self.add_parameter_value(parameter, value)
return self
raise AttributeError(f"Parameter '{parameter}' does not exist")
raise KeyError(f"Parameter '{parameter}' does not exist")

def remove_parameter_value(
self, parameter: str, value: str | int
Expand All @@ -146,7 +146,7 @@ def remove_parameter_value(
if str(value) in values:
values.remove(str(value))
return self
raise AttributeError(f"Parameter '{parameter}' does not exist")
raise KeyError(f"Parameter '{parameter}' does not exist")

def get_query_string(self) -> str:
"""
Expand Down
Loading