Skip to content

refactor: Modify MainViewModel.kt by removing the reference to Contex… #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mayorjay wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor: Modify MainViewModel.kt by removing the reference to Contex… #109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion app/src/main/java/com/naman14/timberx/ui/activities/MainActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
*/
package com.naman14.timberx.ui.activities

import android.annotation.SuppressLint
import android.content.Intent
import android.content.Intent.ACTION_VIEW
import android.os.Bundle
Expand Down
17 changes: 9 additions & 8 deletions app/src/main/java/com/naman14/timberx/ui/viewmodels/MainViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,15 @@
*/
package com.naman14.timberx.ui.viewmodels

import android.app.Application
import android.content.Context
import android.os.Bundle
import android.support.v4.media.MediaBrowserCompat
import android.support.v4.media.session.MediaControllerCompat
import androidx.appcompat.app.AppCompatActivity
import androidx.lifecycle.AndroidViewModel
import androidx.lifecycle.LiveData
import androidx.lifecycle.MutableLiveData
import androidx.lifecycle.ViewModel
import androidx.mediarouter.app.MediaRouteButton
import androidx.mediarouter.media.MediaControlIntent.CATEGORY_LIVE_AUDIO
import androidx.mediarouter.media.MediaControlIntent.CATEGORY_REMOTE_PLAYBACK
Expand Down Expand Up @@ -72,13 +73,13 @@ import timber.log.Timber.e as loge
import timber.log.Timber.w as warn

class MainViewModel(
private val context: Context,
@get:JvmName("getContext_") val application: Application,
private val mediaSessionConnection: MediaSessionConnection,
private val songsRepository: SongsRepository,
private val artistRepository: ArtistRepository,
private val albumRepository: AlbumRepository,
private val playlistsRepository: PlaylistRepository
) : ViewModel() {
) : AndroidViewModel(application) {

val rootMediaId: LiveData<MediaID> =
mediaSessionConnection.isConnected.map { isConnected ->
Expand Down Expand Up @@ -250,7 +251,7 @@ class MainViewModel(
addControlCategory(CATEGORY_LIVE_AUDIO)
}.build().asBundle())

MediaRouter.getInstance(context).apply {
MediaRouter.getInstance(application).apply {
addCallback(selector, object : MediaRouter.Callback() {
override fun onRouteChanged(router: MediaRouter?, route: MediaRouter.RouteInfo?) {
super.onRouteChanged(router, route)
Expand All @@ -260,7 +261,7 @@ class MainViewModel(
}, CALLBACK_FLAG_REQUEST_DISCOVERY)
}

CastButtonFactory.setUpMediaRouteButton(context.applicationContext, mediaRouteButton)
CastButtonFactory.setUpMediaRouteButton(application.applicationContext, mediaRouteButton)
} else {
log("setupCastButton() - Play services not available")
}
Expand All @@ -269,11 +270,11 @@ class MainViewModel(
fun setupCastSession() {
try {
isPlayServiceAvailable = GoogleApiAvailability
.getInstance().isGooglePlayServicesAvailable(context) == ConnectionResult.SUCCESS
.getInstance().isGooglePlayServicesAvailable(application) == ConnectionResult.SUCCESS

if (isPlayServiceAvailable) {
log("setupCastSession()")
val castContext = CastContext.getSharedInstance(context.applicationContext)
val castContext = CastContext.getSharedInstance(application.applicationContext)
sessionManager = castContext.sessionManager
if (castSession == null) {
castSession = sessionManager?.currentCastSession.also {
Expand Down Expand Up @@ -350,7 +351,7 @@ class MainViewModel(

private fun startCastServer() {
log("startCastServer()")
castServer = CastServer(context)
castServer = CastServer(application)
try {
castServer?.start()
} catch (e: IOException) {
Expand Down