feat: add env-driven config/CLI precedence and PK-less safety guards#4
Merged
Conversation
- Support `database.url` placeholders `${VAR}` and `${VAR_FILE}` in YAML config
- Fail fast for missing env vars and unreadable `_FILE` targets
- Add extract env defaults:
- `DATABASE_URL`
- `DBSLICE_DEPTH`
- `DBSLICE_DIRECTION`
- `DBSLICE_OUTPUT_FORMAT`
- `DBSLICE_ANONYMIZE`
- `DBSLICE_REDACT_FIELDS`
- Enforce precedence: `CLI > Env > Config`
- Allow `init` and `inspect` to fallback to `DATABASE_URL` when URL arg is omitted
- Harden PK-less behavior:
- error on PK-less seed tables
- skip non-seed PK-less PK/FK fetch paths safely with warnings
- Update docs for placeholder semantics, env formats, and precedence
- Add unit/integration coverage for env resolution/fallback and PK-less safety
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
database.urlplaceholders${VAR}and${VAR_FILE}in YAML config_FILEtargetsDATABASE_URLDBSLICE_DEPTHDBSLICE_DIRECTIONDBSLICE_OUTPUT_FORMATDBSLICE_ANONYMIZEDBSLICE_REDACT_FIELDSCLI > Env > Configinitandinspectto fallback toDATABASE_URLwhen URL arg is omitted