Skip to content

Add iroh-rings in "Libraries and protocols" section#48

Merged
matheus23 merged 4 commits into
n0-computer:mainfrom
rikettsie:feat/add-iroh-rings-protocol
May 26, 2026
Merged

Add iroh-rings in "Libraries and protocols" section#48
matheus23 merged 4 commits into
n0-computer:mainfrom
rikettsie:feat/add-iroh-rings-protocol

Conversation

@rikettsie

Copy link
Copy Markdown
Contributor

Added iroh-rings under "Libraries and protocols".

@flub flub left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

flub
flub previously requested changes May 26, 2026

@flub flub left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mind removing the malai.sh entry to make the linter happy?

@rikettsie

Copy link
Copy Markdown
Contributor Author

mind removing the malai.sh entry to make the linter happy?

Done, @flub !

@rikettsie

rikettsie commented May 26, 2026

Copy link
Copy Markdown
Contributor Author

For this last linter issue, i could set the asdf-vm/actions/install@v3 in this PR, if you agree.

@matheus23

Copy link
Copy Markdown
Member

Yeah let's maybe try that. Thank you for that!

@rikettsie

Copy link
Copy Markdown
Contributor Author

Sounds good, @matheus23 !

@matheus23

Copy link
Copy Markdown
Member

sigh

@rikettsie

Copy link
Copy Markdown
Contributor Author

I'm better looking into it @matheus23

@rikettsie

Copy link
Copy Markdown
Contributor Author

I set setup-node instead of asdf in GitHub CI, run the workflow in my fork and it works.
I cherry-picked the commit in this PR. Should work.

@matheus23 matheus23 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! We all much prefer not depending on asdf.

@matheus23 matheus23 merged commit 9105b5b into n0-computer:main May 26, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants