[Greenwich] Add DVLA lookup for Greenwich

[MorayMySoc]

https://github.com/mysociety/societyworks/issues/5560

[skip changelog]

[codecov]

Codecov Report

❌ Patch coverage is 57.14286% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.36%. Comparing base (b62aafb) to head (43b421c).

Files with missing lines	Patch %	Lines
web/cobrands/fixmystreet-uk-councils/dvla.js	57.14%	6 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6027      +/-   ##
==========================================
- Coverage   83.36%   83.36%   -0.01%     
==========================================
  Files         500      500              
  Lines       37418    37422       +4     
  Branches     6176     6176              
==========================================
+ Hits        31195    31196       +1     
- Misses       4415     4418       +3     
  Partials     1808     1808              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[struan]

looks good.

[MorayMySoc]

Hi @struan - turns out cars under 3 years old are exempt from MOT and it returns 'No details held by DVLA'. But figure it's better to just work against 'Not valid' if that makes sense https://developer-portal.driver-vehicle-licensing.api.gov.uk/apis/vehicle-enquiry-service/v1.2.0-vehicle-enquiry-service.json

[struan]

One small request for a comment, plus to reflect the 3 year thing in the main MOT status check.

[struan]

I guess maybe a comment here to explain the 3 year thing? Should also update the generic case further down the file too.

Do we know what "No results returned" means? I can't tell from the documentation why that would happen.

[MorayMySoc]

I don't really know - it looks maybe like it's vehicles that may never have been registered somewhere in some way - like old cars which are exempt, but never expected to be on the system

[struan]

looks good