Show pin legends on map#5977
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5977 +/- ##
==========================================
- Coverage 83.41% 83.38% -0.03%
==========================================
Files 500 500
Lines 37341 37358 +17
Branches 6167 6167
==========================================
+ Hits 31147 31150 +3
- Misses 4386 4400 +14
Partials 1808 1808 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@dracos I just added some version for mobile(/around and /reports pages) |
|
The design of this supersedes #5586, but that PR's approach to configuring pin colours per-cobrand might be worth using. |
|
For tablet I need to add a click for the desktop version. |
3211e7f to
6ff37e0
Compare
- On mobile `around` page is a toggle button inside the map that will display a panel with the legends. - On mobile `` because we don't have the space in the map like we do in `around` page is a drawer. - On desktop and tablet a horizontal slide button will display a panel with the legends.
6ff37e0 to
12fd8be
Compare
|
@davea I left this PR ready for review, but it's not really ready for merge. It needs all the back-end changes so we use the pins and legends from each cobrand. |
davea
left a comment
There was a problem hiding this comment.
This looks great! Dev work to add per-cobrand colours being tracked here: https://github.com/mysociety/societyworks/issues/5595.
Fixes: https://github.com/mysociety/societyworks/issues/5466
TODOs
.map_linksTODOs Developer
The only that comes to mind is:
Notes:
pin-legend-wrapper--previewfor something else, for now it seem like a good approach for now. Considering that we have cobrands that use other pins, those previews could be problematic to implement.Desktop
Screen.Recording.2026-06-16.at.06.48.09.mov
Keyboard navigation
Screen.Recording.2026-06-16.at.06.51.46.mov
Mobile
Reports page
Screen.Recording.2026-05-18.at.09.28.23.mov
Around page
Screen.Recording.2026-05-18.at.10.11.05.mov