Don't wrap the overridden element with a container#21
Open
stuckj wants to merge 2 commits into
Open
Conversation
added 2 commits
September 29, 2017 14:24
The wrapper causes problems with inputs that use :focus to, e.g., change the underline border color or animate moving placeholder text via CSS only. Without having the input as a sibling this can only be done with javascript (unless you're only dealing with one input on the whole page).
Owner
|
I'm not quite sure what problem that solves. Currently, you'd get a markup like: What prevents you from using focus here? I am sure that there are also scenarios where this would lead to an issue: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current code is wrapping the original input and the generated input
with a container
span. The wrapper causes problems with inputs thatuse :focus to, e.g., change the underline border color or animate moving
placeholder text via CSS. This can only be done with javascript without
having the input as a sibling except in the trivial case where there is only
one input on the page.