Skip to content

remove header from pool if proof sync fails#7840

Closed
sstanculeanu wants to merge 4 commits into
feat/testnet-fixesfrom
remove-header-on-sync
Closed

remove header from pool if proof sync fails#7840
sstanculeanu wants to merge 4 commits into
feat/testnet-fixesfrom
remove-header-on-sync

Conversation

@sstanculeanu

Copy link
Copy Markdown
Collaborator

Reasoning behind the pull request

Proposed changes

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@codecov

codecov Bot commented May 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.55%. Comparing base (5adab78) to head (4e76a11).

Additional details and impacted files
@@                  Coverage Diff                   @@
##           feat/testnet-fixes    #7840      +/-   ##
======================================================
+ Coverage               77.53%   77.55%   +0.01%     
======================================================
  Files                     883      883              
  Lines                  124506   124535      +29     
======================================================
+ Hits                    96536    96579      +43     
+ Misses                  21558    21543      -15     
- Partials                 6412     6413       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AdoAdoAdo AdoAdoAdo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this branch can be dropped we already have the handling for this case in the feat/testnet-fixes with a slightly more complete approach.

@sstanculeanu sstanculeanu deleted the remove-header-on-sync branch June 29, 2026 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants