Update json-c to latest (d1018cf)#4948
Open
Lpsd wants to merge 5 commits into
Open
Conversation
Historically we've hotfixed this into the vendor, now we don't need to
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade json-c to current upstream master (d1018cf).
As a bonus, the
%.16gdouble serialization fix that previously required patchingjson_object.cevery upgrade is now done through the public API (json_c_set_serialization_double_format), so future json-c drops should need zero source modifications.Motivation
Keeping it fresh 🥦
Notable changes
%.17gto%.16gprecision fix moves from a source patch to a one-time API call at server & client startup (seeCClientGame/CGame). The existing startup self-check still validates the fix.toJSON/fromJSON. Start it withstart jsonand checktoJSON(5.1)does not leak IEEE 754 LSB artifacts.Test plan
json.zip
Start the resource and confirm the startup precision check passes (no "JSON built without precision modification" warning in logs). Start the json test resource and verify all round-trip tests pass.
toJSON/fromJSONin Lua scripts should behave identically to before.Checklist