Replace tinyxml with tinyxml2#4942
Open
Lpsd wants to merge 9 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the unmaintained tinyxml library with tinyxml2 11.x (master: https://github.com/leethomason/tinyxml2).
The full XML wrapper layer (CXMLImpl, CXMLFileImpl, CXMLNodeImpl, CXMLAttributeImpl, CXMLAttributesImpl) has been updated to the new API. tinyxml2 ships as a single header and .cpp with no extra dependencies, so it drops straight into vendor/ alongside the existing premake setup.
Motivation
tinyxml(1) has not been updated for a long time.
tinyxml2 is actively maintained by the same original author, handles the same XML subset we use, and has a cleaner modern C++ API.
Notable differences from the old library
This is not a fully transparent swap -- the two libraries have meaningfully different ownership semantics:
Test plan
Start the server with default resources and confirm it launches without issues/crashing.
Also worth checking (already tested lightly):
CopyNodesettings node)aclrequest allow <resource> allsuccessfully saves the acl.xmlChecklist