Fix no footsteps during walking animations (#4359)

[FileEX]

Fixed #4359

Some animations allow walking (e.g., crry_partial, silence_reload) or are entirely based on walking (e.g., wuzi_walk, wuzi_cs_pt1). During these animations, there are no footstep sounds, no footprints, no blood trails, and the onClientPedStepevent is not triggered.

This PR, following the new guidelines, is based on reverse engineering - the CPed::PlayFootSteps function has been reversed and appropriately modified to fix the bug, instead of using an ASM hook.

[tederis]

I just have tried it. And I have a question. Based on what did you choose animations wuzi_walk and wuzi_cs_pt1? And why do you spare other animations (from ped block, for example)? This solution is kinda... incomplete currently.

[FileEX]

I just have tried it. And I have a question. Based on what did you choose animations wuzi_walk and wuzi_cs_pt1? And why do you spare other animations (from ped block, for example)? This solution is kinda... incomplete currently.

It’s about partial animations that allow walking, and I only know of two: crry_prtial and silence_reload. There may be more, but I don’t know them.

Also, there are animations that consist only of walking and can be looped, namely wuzi_walk and wuzi_cs_pt1. I don’t know of any other animations that allow looping walking.

We’re not talking about animations where the character takes two steps and then sits down, but strictly those that are continuously about walking. There are probably more of these, but I only know those two. If you know more such animations, list them here and I’ll add them.

[tederis]

If you know more such animations, list them here and I’ll add them.

Some of looped animations from ped block:

run_1armed
run_armed
run_civi
run_csaw
run_fat
run_fatold
run_gang1
run_left
run_old
run_player
run_right
run_rocket
run_stop
run_stopr
run_wuzi
sprint_civi
sprint_panic
sprint_wuzi
swat_run
walk_armed
walk_civi
walk_csaw
walk_doorpartial
walk_drunk
walk_fat
walk_fatold
walk_gang1
walk_gang2
walk_old
walk_player
walk_rocket
walk_shuffle
walk_start
walk_start_armed
walk_start_csaw
walk_start_rocket
walk_wuzi
woman_run
woman_runbusy
woman_runfatold
woman_runpanic
woman_runsexy
woman_walkbusy
woman_walkfatold
woman_walknorm
woman_walkold
woman_walkpro
woman_walksexy
woman_walkshop

And that's not all the animations, you can find more.

[github-actions]

This draft pull request is stale because it has been open for at least 90 days with no activity. Please continue on your draft pull request or it will be closed in 30 days automatically.

[RughCuttle]

Question, Would this draft solve #3915 , #2733 , #3055 ?

[FileEX]

Question, Would this draft solve #3915 , #2733 , #3055 ?

No