Skip to content

Fix createlogentries attachments annotation - #105

Merged
woswos merged 2 commits into
masterfrom
fix-createlogentries-attachments-annotation
Sep 23, 2026
Merged

woswos merged 2 commits into
masterfrom
fix-createlogentries-attachments-annotation

Conversation

@eisoku9618

Copy link
Copy Markdown
Member
def CreateLogEntries(logEntries: List[Tuple[str, Union[bytes, Any], Attachments]]) -> None:
    logEntries.append(('aaa', b'ALREADY-ENCODED-JSON', None)) #  this is ok according to the type hint of this function

callerBatch: list[tuple[str, dict, Attachments]] = [('bbb', {'ccc': 1}, None)]
CreateLogEntries(callerBatch) # mypy complains here. The loop below is why that rule exists.

for logType, logEntry, attachments in callerBatch:
    logEntry['uploaded'] = True

@eisoku9618
eisoku9618 requested a review from woswos September 23, 2026 02:30
@woswos
woswos merged commit 40778a2 into master Sep 23, 2026
1 check passed
@woswos

woswos commented Sep 23, 2026

Copy link
Copy Markdown
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants