Add certificate get/put APIs - #104
Merged
Merged
Conversation
woswos
reviewed
Sep 11, 2026
woswos
reviewed
Sep 11, 2026
Addresses review feedback: GetCertificate now behaves like the other resource APIs, raising APIServerError when nothing is stored under the requested id instead of returning None. APICall gains parseJSONResponse so endpoints whose successful response is not JSON, such as the PEM certificate download, can still go through it and pick up its error handling. Error bodies are decoded as JSON either way, since webstack reports every error that way regardless of the content type it serves on success. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
woswos
reviewed
Sep 11, 2026
woswos
approved these changes
Sep 13, 2026
Contributor
Author
|
Pipeline #2106717 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.