RGBColor.Sequence truncates each channel with uint8(f.R*255) (and G/B) after colorful.Hex converts token integers to floats. Floating-point representation can put the product just below the original integer, losing one channel step in both foreground and background SGR.
Reproduction with termenv v0.16.0 and go-colorful v1.4.0:
fmt.Println(termenv.RGBColor("#657084").Sequence(false))
// actual: 38;2;101;112;131
// expected: 38;2;101;112;132
fmt.Println(termenv.RGBColor("#eceff4").Sequence(true))
// actual: 48;2;236;239;243
// expected: 48;2;236;239;244Other examples: #4c566a emits #4c5669; #2d6271 emits #2c6171. We found this while checking the actual Lip Gloss output against shared web/TUI design tokens in sachiniyer/agent-factory#3937.
Could RGBColor.Sequence use f.RGB255() (which rounds) or parse the integer channels directly? A local scratch change to r, g, b := f.RGB255() preserves all 12 of our roles in both themes for foreground and background. A regression test covering all 256 channel values would guard the full range.
We are retaining the released dependency and documenting a temporary one-step-per-channel tolerance downstream; we can tighten that test to exact bytes when a fixed release is available.
RGBColor.Sequencetruncates each channel withuint8(f.R*255)(and G/B) aftercolorful.Hexconverts token integers to floats. Floating-point representation can put the product just below the original integer, losing one channel step in both foreground and background SGR.Reproduction with termenv v0.16.0 and go-colorful v1.4.0:
Other examples:
#4c566aemits#4c5669;#2d6271emits#2c6171. We found this while checking the actual Lip Gloss output against shared web/TUI design tokens in sachiniyer/agent-factory#3937.Could
RGBColor.Sequenceusef.RGB255()(which rounds) or parse the integer channels directly? A local scratch change tor, g, b := f.RGB255()preserves all 12 of our roles in both themes for foreground and background. A regression test covering all 256 channel values would guard the full range.We are retaining the released dependency and documenting a temporary one-step-per-channel tolerance downstream; we can tighten that test to exact bytes when a fixed release is available.