fix(kokoro): add explicit click dep so spacy CLI works on intel build#10572
Merged
Conversation
The kokoro install.sh ends with `python -m spacy download en_core_web_sm`.
spaCy's CLI imports typer -> click, so click must be present at that point.
On the intel build profile, install.sh adds `--upgrade --index-strategy=unsafe-first-match`
against the Intel pip index. With that resolution strategy, click is not
resolved/installed, so the spacy CLI import fails with:
ModuleNotFoundError: No module named 'click'
make: *** [Makefile:3: kokoro] Error 1
Other profiles (cpu/cublas) pull click in transitively and build fine; only
the intel profile breaks. This surfaced in the v4.5.5 release CI as the
gpu-intel-kokoro backend image build failure.
Make click an explicit dependency in the base requirements.txt (installed for
every profile) so it is always present before `python -m spacy download` runs,
regardless of index resolution. Unpinned: spacy constrains the version.
Assisted-by: Claude:claude-opus-4-8 [Claude Code]
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
mudler
approved these changes
Jun 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the v4.5.5 release CI, the backend image build job
gpu-intel-kokoro(linux/amd64, Intel oneAPI) failed:Root cause
backend/python/kokoro/install.shends with:python -m spacyloads spaCy's CLI, which importstyper->click, soclickmust be installed at that point.On the intel build profile, install.sh adds
--upgrade --index-strategy=unsafe-first-matchagainst the Intel pip index. With that resolution strategy,clickdoes not get resolved/installed, so the spacy CLI import fails. Other profiles (cpu/cublas) pullclickin transitively and build fine; only the intel profile breaks.Fix
Add
clickas an explicit dependency in the basebackend/python/kokoro/requirements.txt, whichinstallRequirementsinstalls for every profile (base + per-profile). This guaranteesclickis present beforepython -m spacy downloadruns, regardless of index resolution. The version is left unpinned so spacy constrains it.Found in the v4.5.5 release CI
gpu-intel-kokorobuild failure.