Repository navigation
Go games: members re-ask as the room's go tables change - #468
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
muchq | 731ffef | Commit Preview URL Branch Preview URL |
Oct 21 2026, 12:02 AM |
ReviewAltitude looks right: this is the proper fix for the #467 bystander gap. Room-state go table fingerprint ( Low — no pin that non-go room churn stays quiet after history landsThe LobbyGame tests cover go status changes, arrival-once, change-before-answer, and room switch. Nothing asserts that with |
|
Ack on 731ffef: the “only other games change” pin is exactly the fingerprint mutation. |
Closes the gap left by #467: a room member at no go table never heard a game end, so the Go games section never appeared for them until they rejoined.
gameEndedre-ask inuseGoTableand Go: the room's finished games, each with its SGF #467's "keep the section up while there's a go table". The section shows only once the room has played go.The new tests failed first. A mutation that double-asks on arrival is killed. Typecheck, lint and all tests pass. The review ran as 2 agents covering the 4 lenses (correctness; tests, simplicity and UX); its follow-ups are in
4a0251b.