Repository navigation
games_hub: pin chess terms and round robin body bytes - #1677
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
1d4-web | 739e506 | Commit Preview URL Branch Preview URL |
Oct 18 2026, 07:41 PM |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
iili | 739e506 | Commit Preview URL Branch Preview URL |
Oct 18 2026, 07:41 PM |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
ast-lol | 739e506 | Commit Preview URL Branch Preview URL |
Oct 18 2026, 07:41 PM |
CI:
|
Review: pin chess terms and round robin body bytesVerdict: Approve. Right “pin first” for #1668 phase 1: test-only, goldens are the live write shape, and the read side asserts by write-back rather than naming row fields — so the terms refactor can change the C++ shape without rewriting these pins. Tip What worksWaiting chess terms. Round robin bodies. Chess: no Comparison. Disclosed non-acts. Overlap with Tip |
#1668 phase 1, "pin first". Test-only.
PinnedBytesTestinpg_hub_store_test, compared as jsonb text (keeps key sets and integer vs float):{"terms":{…}}ingames.stategame, emptywithdrawn)game,variant:"3d", two withdrawn, and today's unused zeroed chessterms)Each is written from a row and must equal the golden. The golden is also loaded (LoadGame; LoadRoom and LoadSnapshot) and written back, and must come out unchanged. The read side names no row fields, so it survives the terms refactor unchanged. Fixtures cover every pairing shape and unsorted entrants.
Pong's
termskey is pinned as written today. When pong's variant folds into its own terms, dropping it from the write is a deliberate golden change; old rows still carry it.Verified against local Postgres, no skips.
scripts/mutation-checkfiltered toPinnedBytesTest.*: 7/7 killed (renamed terms key on write ×2, floatinitialMs, init/increment swapped on both reads,forfeit:falsewritten, pong variant dropped on read).Review panel ran (four lenses); fixups in 739e506. Not acted on: deduping the older
ChallengeTermsRide…/ARoundRobinBodyNames…assertions these overlap (they also pin refusals and the started row).🤖 Generated with Claude Code
https://claude.ai/code/session_01Xae1QBa2qHX32DPVGSq19F