Skip to content

games_hub: games started/finished counters by game and outcome - #1675

Merged
aaylward merged 3 commits into
mainfrom
claude/zen-euler-y3qze2
Oct 17, 2026
Merged

aaylward merged 3 commits into
mainfrom
claude/zen-euler-y3qze2

Conversation

@aaylward

Copy link
Copy Markdown
Collaborator

Closes #1670.

  • games_started{game} and games_finished{game, outcome}, recorded beside the game_started/game_finished lines in their variant/outcome vocabulary. They're declared at zero for every recorded word × outcome (rummy uses kRecordedNames, which a test holds to recordedName).
  • prom_proxy: a "Games" group with started/completed/abandoned tiles and abandon_rate. Charts are game_started (fixed) and game_abandon_rate (mean).
  • otel_contract: the registry's outcome= values must be the hub's kOutcome*.

Not done:

  • Completed/abandoned charts and per-game tile splits. Either would go past the 48-range-query page budget, and the registry has no split primitive.
  • Optional ending label and duration histogram.
  • UI check in muchq.github.io.

The review panel was not run.


Generated by Claude Code

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
1d4-web 3645d18 Commit Preview URL

Branch Preview URL
Oct 17 2026, 07:18 PM

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
iili 3645d18 Commit Preview URL

Branch Preview URL
Oct 17 2026, 07:19 PM

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
ast-lol 3645d18 Commit Preview URL

Branch Preview URL
Oct 17 2026, 07:19 PM

@github-actions github-actions Bot added service:games_hub Changes the games_hub image service:prom_proxy Changes the prom_proxy image labels Oct 17, 2026
@aaylward
aaylward force-pushed the claude/zen-euler-y3qze2 branch from 9adb86d to 18ead76 Compare October 17, 2026 19:15
@cursor

cursor Bot commented Oct 17, 2026

Copy link
Copy Markdown

Review: games started/finished counters by game and outcome

Verdict: Approve. Closes #1670 on the live path: games_started{game} / games_finished{game, outcome} beside the game_* event lines, same vocabulary, declared at zero, wired into prom_proxy's Games group. Tip 18ead762. CI restarting after the rebase onto main.

What works

Hub. CountGameStarted / CountGameFinished sit next to GameStartedLine / GameFinishedLine — open-starts path uses GameKindName, deal-starts / finish use VariantWordOf / FinishedOf, so rummy deals land under rummy/gin and the finish gate (finish && !was_over) is the same one that prevents double-recording. DeclaredCounterSeries walks every adapter; rummy swaps in kRecordedNames ({"rummy","gin"}), held to recordedName by EveryRummyVariantIsRecordedUnderADeclaredWord.

Tests. Declaration list in hub_e2e covers all eight recorded words × both outcomes. Chess e2e pins completed (resign) and abandoned (leave). Registry audit extended for games_* names and outcome=; otel_contract pins prom_proxy's selected outcomes to hub kOutcome*. TestRegistry_GamesHubCountsGamesPlayed locks tile queries and the abandon_rate tile/chart agreement.

prom_proxy. Games group: started / completed / abandoned tiles + abandon_rate mean. Charts stay on budget (game_started fixed, game_abandon_rate mean); completed/abandoned charts and per-game splits correctly deferred as the PR body says. Handler test updated for the 13th group and omitted-last-tile contract.

Non-blocking

  • rummy_adapter.h comment names EveryVariantIsRecordedUnderADeclaredWord; the test is EveryRummyVariantIsRecordedUnderADeclaredWord.
  • Review panel was not run (disclosed).

Tip 18ead762. Closes #1670.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PF5CZafkFhmkCfxasKpme9
@cursor

cursor Bot commented Oct 17, 2026

Copy link
Copy Markdown

Tip 3645d181

Comment-only: rummy_adapter.h now names EveryRummyVariantIsRecordedUnderADeclaredWord. Approve unchanged. CI restarting on this tip.

@github-actions github-actions Bot added the service:unknown Impacted services could not be computed label Oct 17, 2026
@aaylward
aaylward merged commit ac58fa8 into main Oct 17, 2026
24 checks passed
@aaylward
aaylward deleted the claude/zen-euler-y3qze2 branch October 17, 2026 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

service:games_hub Changes the games_hub image service:prom_proxy Changes the prom_proxy image service:unknown Impacted services could not be computed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

games_hub: games started/finished metrics by kind and outcome

2 participants