Repository navigation
chore(ci): drop the Marketplace PAT liveness probe now that publishing uses OIDC - #505
Merged
Merged
Conversation
…g uses OIDC publish.yml publishes to the Marketplace via OIDC Trusted Publishing, so VSCODE_PAT is no longer used and is about to be deleted. The weekly probe would go red on the empty secret. - token-liveness.yml: remove the vsce verify-pat step and rewrite the comments around the single Open VSX probe; note that the OIDC leg cannot be probed from a cron. - readonly test: drop the Marketplace pins and pin that the workflow no longer references VSCODE_PAT. - publish.yml: replace the stale vsce 4.0.0 --help note with the >= 4.1.0 requirement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Marketplace publishing moved to OIDC Trusted Publishing (#501, #503), and v0.1.87 shipped to both registries that way.
publish.ymlno longer readsVSCODE_PAT, and the secret is about to be deleted. Once it is gone, the weeklytoken-liveness.ymlrun would go red on the empty-secret guard for a credential nothing uses.What
.github/workflows/token-liveness.yml: remove thevsce verify-patstep. The Open VSX probe stays as the only one. Its!cancelled() && steps.publisher.outcome == 'success'condition is gone too: with one probe there is nothing left to mask, and the default already skips it when setup fails. The header now explains why the Marketplace isn't probed: there is no long-lived token, and OIDC failures, such as the vsce < 4.1.0 token-exchange bug, only show up in a real publish. Workflow renamed to "Open VSX Token Liveness".test/build/token-liveness-workflow-readonly.test.ts: drop the Marketplace pins. The CLI allowlist is now just theovsx verify-patline, and it still matchesvsce, so a reintroduced call fails. Adds a pin that the comment-stripped workflow no longer referencesVSCODE_PAT/VSCE_PAT..github/workflows/publish.yml: the note that--oidcis hidden fromvsce publish --helpin 4.0.0 was stale (4.1.1 lists it). It now says vsce >= 4.1.0 is required.scripts/deploy.shstill mentionsVSCE_PAT. That is the manual local publish path, so it is left as is.Verification
pnpm compile: greenpnpm vitest run test/build/token-liveness-workflow-readonly.test.ts: 9/9 passorigin/mainworkflow swapped in, the CLI-allowlist test and the newVSCODE_PATpin both fail (2 failed / 7 passed); the file was then restoredpnpm exec biome checkon the test file: clean