Skip to content

chore(ci): drop the Marketplace PAT liveness probe now that publishing uses OIDC - #505

Merged
mtskf merged 3 commits into
mainfrom
chore/drop-marketplace-pat-probe
Nov 20, 2026
Merged

mtskf merged 3 commits into
mainfrom
chore/drop-marketplace-pat-probe

Conversation

@mtskf

@mtskf mtskf commented Nov 20, 2026

Copy link
Copy Markdown
Owner

Why

Marketplace publishing moved to OIDC Trusted Publishing (#501, #503), and v0.1.87 shipped to both registries that way. publish.yml no longer reads VSCODE_PAT, and the secret is about to be deleted. Once it is gone, the weekly token-liveness.yml run would go red on the empty-secret guard for a credential nothing uses.

What

  • .github/workflows/token-liveness.yml: remove the vsce verify-pat step. The Open VSX probe stays as the only one. Its !cancelled() && steps.publisher.outcome == 'success' condition is gone too: with one probe there is nothing left to mask, and the default already skips it when setup fails. The header now explains why the Marketplace isn't probed: there is no long-lived token, and OIDC failures, such as the vsce < 4.1.0 token-exchange bug, only show up in a real publish. Workflow renamed to "Open VSX Token Liveness".
  • test/build/token-liveness-workflow-readonly.test.ts: drop the Marketplace pins. The CLI allowlist is now just the ovsx verify-pat line, and it still matches vsce, so a reintroduced call fails. Adds a pin that the comment-stripped workflow no longer references VSCODE_PAT / VSCE_PAT.
  • .github/workflows/publish.yml: the note that --oidc is hidden from vsce publish --help in 4.0.0 was stale (4.1.1 lists it). It now says vsce >= 4.1.0 is required.

scripts/deploy.sh still mentions VSCE_PAT. That is the manual local publish path, so it is left as is.

Verification

  • pnpm compile: green
  • pnpm vitest run test/build/token-liveness-workflow-readonly.test.ts: 9/9 pass
  • Non-vacuity: with the origin/main workflow swapped in, the CLI-allowlist test and the new VSCODE_PAT pin both fail (2 failed / 7 passed); the file was then restored
  • pnpm exec biome check on the test file: clean
  • Both workflows parse with js-yaml (actionlint isn't installed)

…g uses OIDC

publish.yml publishes to the Marketplace via OIDC Trusted Publishing, so
VSCODE_PAT is no longer used and is about to be deleted. The weekly probe
would go red on the empty secret.

- token-liveness.yml: remove the vsce verify-pat step and rewrite the
  comments around the single Open VSX probe; note that the OIDC leg cannot
  be probed from a cron.
- readonly test: drop the Marketplace pins and pin that the workflow no
  longer references VSCODE_PAT.
- publish.yml: replace the stale vsce 4.0.0 --help note with the >= 4.1.0
  requirement.
@mtskf
mtskf merged commit 040b87d into main Nov 20, 2026
2 checks passed
@mtskf
mtskf deleted the chore/drop-marketplace-pat-probe branch November 20, 2026 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant