[codex] Sort NavLog radio frequencies by route order#779
Merged
Conversation
Contributor
🚀 Preview deployed
Commit: |
4230616 to
724baea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The NavLog frequency list was built directly from
state.notes, so it followed note insertion/storage order instead of the order a pilot reaches those waypoints.A second issue caused the Herzliya -> Beer Sheva template to show Country Club / Herzliya at the end: comm-change auto-seeding used screen-pixel distance to match a route waypoint to a comm-change point. At fit zoom, the known waypoint
HTZUKwas close enough on screen to the known comm pointKNTRY, so the reverse-route Country Club frequency was created as an unmapped note and then sorted last.Validation
node --check docs/app/draw.jsnode --check docs/app/io.jsnode --check tests/nav-log.spec.jsgit diff --checknpx playwright test tests/nav-log.spec.jsFixes #778