Skip to content

[codex] Sort NavLog radio frequencies by route order#779

Merged
github-actions[bot] merged 2 commits into
devfrom
codex/navlog-freq-route-order
Jun 16, 2026
Merged

[codex] Sort NavLog radio frequencies by route order#779
github-actions[bot] merged 2 commits into
devfrom
codex/navlog-freq-route-order

Conversation

@msupino

@msupino msupino commented Jun 16, 2026

Copy link
Copy Markdown
Owner

Summary

  • Sort the NavLog comm-change frequency list by each callout route waypoint index.
  • Keep unmapped frequency notes stable after mapped route frequencies.
  • Prevent known route waypoints from snapping to a different nearby comm-change point at low zoom.
  • Add regression tests for route-order sorting and the Herzliya -> Beer Sheva Country Club false positive.

Root cause

The NavLog frequency list was built directly from state.notes, so it followed note insertion/storage order instead of the order a pilot reaches those waypoints.

A second issue caused the Herzliya -> Beer Sheva template to show Country Club / Herzliya at the end: comm-change auto-seeding used screen-pixel distance to match a route waypoint to a comm-change point. At fit zoom, the known waypoint HTZUK was close enough on screen to the known comm point KNTRY, so the reverse-route Country Club frequency was created as an unmapped note and then sorted last.

Validation

  • node --check docs/app/draw.js
  • node --check docs/app/io.js
  • node --check tests/nav-log.spec.js
  • git diff --check
  • npx playwright test tests/nav-log.spec.js

Fixes #778

@github-actions

github-actions Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

🚀 Preview deployed

Open PR preview →

https://msupino.github.io/NavigationApp/branch/codex/navlog-freq-route-order/

Commit: 55ac9a4

@msupino msupino force-pushed the codex/navlog-freq-route-order branch from 4230616 to 724baea Compare June 16, 2026 16:12
@msupino msupino marked this pull request as ready for review June 16, 2026 16:20
@github-actions github-actions Bot enabled auto-merge (squash) June 16, 2026 16:20
@github-actions github-actions Bot merged commit 2e470a4 into dev Jun 16, 2026
12 checks passed
@msupino msupino deleted the codex/navlog-freq-route-order branch June 16, 2026 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant