✨ Approachable concurrency + Lots of code refactoring#1015
Merged
Conversation
…are cached target frames
# Conflicts: # Loop/Core/WindowDragManager.swift
# Conflicts: # Loop/Window Management/Window Manipulation/WindowEngine.swift
# Conflicts: # Loop/Core/WindowDragManager.swift
mrkai77
force-pushed
the
concurrency-and-improvements
branch
from
92937e2 to
fc4149e
Compare
6 tasks
mrkai77
force-pushed
the
concurrency-and-improvements
branch
from
16bbaed to
1a55e7d
Compare
# Conflicts: # Loop.xcodeproj/project.pbxproj # Loop/App/AppDelegate.swift # Loop/Icon/IconManager.swift # Loop/Updater/Updater.swift # Loop/Updater/Views/UpdateView.swift
mrkai77
force-pushed
the
concurrency-and-improvements
branch
from
1a55e7d to
70c4353
Compare
# Conflicts: # Loop/Core/URLCommandHandler.swift # Loop/Settings Window/Settings/Keybinds/KeybindItemView.swift # Loop/Window Management/Window Action/WindowActionCache.swift
mrkai77
added a commit
that referenced
this pull request
Jan 26, 2026
mrkai77
added a commit
that referenced
this pull request
Jan 26, 2026
# Conflicts: # Loop/Core/LoopManager.swift # Loop/Core/WindowDragManager.swift
mrkai77
force-pushed
the
concurrency-and-improvements
branch
from
259618a to
a7e6c3e
Compare
SenpaiHunters
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SWIFT_APPROACHABLE_CONCURRENCY) for all build configurations@Loggablemacro across all types that use Scribe to simplify loggingResizeContextstruct to encapsulate window resize state (window, screen, action, parent action, mouse position, etc.) so that all parameters no longer need to be individually passed inWindowActionEngine.shared.apply()method - this now takes in theResizeContextto commit actions.WindowEngineis now specifically for the resizing/moving of windows, whileWindowActionEnginehandles everything else (toggling fullscreen, hiding, minimizing, focusing windows etc.)WindowActionIndicatorServiceto manage preview and radial menu display for LoopManager based on user settings. This could also potentially be helpful in case we add more indicators in the future..screenCenterto.actionCenterhideUntilDirectionIsChosen->hideOnNoSelection- now radial menu can be set to be hidden when its "selected" direction is.noSelection.changeTohideOnNoSelection) to migrate old setting to the new onePaddingModel->PaddingConfigurationnaming, as it gained some more buisness logic!stageStripFreeFrame->safeScreenFrame, addedcgSafeScreenFrame, as these were ambiguous before.LaunchAtLoginManagerto handle login item registration/unregistration, both during app launch and when the user toggles the setting, to better ensure the setting's persistence.