Fix CRAN macOS installation and release 0.1.13 - #8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CRAN macOS builders install Rust under
~/.cargo/binwithout adding it to PATH. Althoughconfigurefinds and validates the toolchain, the build failed on a redundantrustc --versionbefore the existing PATH fallback ran.Remove that redundant check on Unix and Windows, and use the same Cargo PATH fallback on Windows. Add a macOS CI regression check that removes Rust from PATH. Bump the R package to 0.1.13 and document the CRAN fix.
Validation:
configuresuccess followed byrustc: command not foundwith Rust removed from PATH.R CMD check --as-cran --no-manualwith Rust absent from PATH: 0 errors, 0 warnings, 1 note (network-disabled current-time verification). Package loading, examples, and tests passed; the official Debiancheckbashismsutility was supplied.