fix(auth-server): add histogram to disabled StatsD mock#20799
Open
sreecharan-desu wants to merge 1 commit into
Open
fix(auth-server): add histogram to disabled StatsD mock#20799sreecharan-desu wants to merge 1 commit into
sreecharan-desu wants to merge 1 commit into
Conversation
Because: * When StatsD is disabled, key_server uses a no-op metrics client. * Redis metrics callers invoke histogram via optional chaining, which throws if the method is missing on a non-null metrics object. This commit: * Extract a shared createNoopStatsd helper with histogram support. * Use it when config.statsd.enabled is false. * Add unit tests for the no-op client method surface. Fixes mozilla#16491
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
config.statsd.enabledis false,key_server.jsregisters a no-op StatsD client in the DI container.this.metrics?.histogram(...). Optional chaining skips null/undefined objects, but ifmetricsexists without ahistogrammethod, the call throws at runtime.This pull request
createNoopStatsd()helper that implementsincrement,timing,histogram, andclose.key_server.js.Issue that this pull request solves
Closes: #16491
Checklist
How to review (Optional)
packages/fxa-auth-server/lib/noop-statsd.js,packages/fxa-auth-server/bin/key_server.jskey_server.jsTest plan
yarn jest packages/fxa-auth-server/lib/noop-statsd.spec.tspassesSTATSD_ENABLE=falseand redis histogram metrics do not throw