Conversation
vbudhram
force-pushed
the
fxa-13647
branch
3 times, most recently
from
a3887da to
648cca0
Compare
vbudhram
force-pushed
the
fxa-13647
branch
2 times, most recently
from
4cf760a to
c67bd52
Compare
…th tests Because: - Playwright 1.61.1 (Firefox 151) surfaced timing flakes in email-first OAuth flows, and the keys_optional Sync tests needed updating for decoupled Sync. This commit: - Upgrades Playwright to 1.61.1 and fixes the Sync tests for keys_optional. - Waits for the settled /oauth page in the relier email-first and AAL2 nav helpers rather than the intermediate /authorization redirect. - Adds respondToWebChannelMessageAlways for flows that re-dispatch fxa_status, and frames the no-keys_optional mocks as capability-based (Sync not decoupled). - Hardens fillOutEmailFirstForm to retry the email fill until the submit button enables, fixing an email-first re-mount race that left it disabled. - Converts the CMS Sync tests to page-object helpers (fillOutEmailFirstForm, fillOutPasswordForm, connectAnotherDevice) instead of raw locators. - Bumps the fxa-circleci CI images v9 -> v10 so the functional-test-runner ships the Playwright 1.61.1 browsers, and documents the image-update process in .circleci/README.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
keys_optional) changed signin routing, breaking several Sync and OAuth functional tests.This pull request
@playwright/test1.44.1 → 1.61.1 (packages/functional-tests/package.json,yarn.lock).fxa-circleciCI images v9 → v10 (.circleci/config.yml) so the functional-test-runner ships the matching browsers.keys_optionalmocks to be capability-based (Sync not decoupled) rather than browser-version-based invpnIntegration.spec.ts,passkeyPasswordFallback.spec.ts, and thesyncV3/*specs.waitForOauthPage()inrelier.tsso email-first/AAL2 nav waits for the settled/oauthpage, not the intermediate/authorizationredirect.respondToWebChannelMessageAlways()inlayout.tsfor flows that re-dispatchfxa_status.gotoSyncSession()inlib/sync-helpers.tsto abstract/pairnavigation across Sync tests.Issue that this pull request solves
Closes: https://mozilla-hub.atlassian.net/browse/FXA-13647
Checklist
Other information
Requires the
-v10CI image (ci-functional-test-runner-v10) to be published before functional tests pass — built via theupdate-ci-imagebranch /force-deploy-fxa-ci-images. Verify by re-running the "Firefox Functional Tests - Playwright (PR)" job once-v10is in the registry.