chore(auth-server): minor code cleanup and fixes#19940
Conversation
|
This pull request issue has been marked as stale due to inactivity. It will be closed in a week if it continues to be stale. |
dschom
left a comment
There was a problem hiding this comment.
Thanks for these contributions. This PR has grown stale, but you have some nice clean up here. Please see comments and feel free to refile more targeted PRs. We will try to address them in a timely manner this time around.
1910ae5 to
3eb0581
Compare
|
Thanks for the feedback, @dschom! I've updated the PR to address your requests:
I hope this targeted version is much easier to review. Let me know if you need any further adjustments! |
|
This pull request issue has been marked as stale due to inactivity. It will be closed in a week if it continues to be stale. |
c866e48 to
de06dc4
Compare
|
Following up on the earlier review feedback — all requested changes were already addressed, and I've now rebased this branch onto latest Summary of what's in this PR:
Would appreciate a re-review when you have time, @dschom. |
|
Closing this in favor of two focused PRs per @dschom's review feedback:
Both are rebased on latest |
This PR introduces a few targeted cleanups and improvements to the fxa-auth-server package:
SessionTokenmodel to pull its expiry from theauth-serverconfiguration instead of using a hardcoded static value.These changes address the maintainer's feedback regarding targeted PRs and unhardcoding configuration values, while maintaining existing functionality.