Repository navigation
Bug 2082654 - 2_test_flags2.t picks a component before the bug page has loaded the new product's components - #2788
Merged
Merged
Conversation
…as loaded the new product's components
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an intermittent
test_selenium_2failure inqa/t/2_test_flags2.t, seen on #2785 and #2786.On the bug page, changing the product disables the component select and reloads its options asynchronously (
GET /rest/bug_modal/new_product/<bug_id>). The test selected the component right after the product, so depending on timing it got astale element referenceor a missing option (Set selected: c1).Changes
qa/t/2_test_flags2.t: newchange_producthelper that selects the product, waits until the component select is enabled again and offers the wanted component, then selects it. Used for the two product changes on the bug page. The product changes oneditflagtypes.cgifill the list synchronously and are left as they are.qa/t/lib/QA/Util.pm:wait_for_js(poll a script for up to 5 seconds) moved here fromqa/t/2_test_autocomplete.t, so both tests share it.Test-only change.
Test plan
2_test_flags2.tand2_test_autocomplete.tpass locallytest_selenium_2passes in CI on the first runReferences