Skip to content

chore(DENG-11021): complete certain tier 2 backfills#9709

Merged
kbammarito merged 1 commit into
mainfrom
DENG-11021-complete-two-backfills-tier-2
Jul 21, 2026
Merged

chore(DENG-11021): complete certain tier 2 backfills#9709
kbammarito merged 1 commit into
mainfrom
DENG-11021-complete-two-backfills-tier-2

Conversation

@kbammarito

Copy link
Copy Markdown
Contributor

Description

Completes the two Tier 2 cohort_daily_statistics install_source backfills initiated in #9690:

  • telemetry_derived.cohort_daily_statistics_v2
  • glean_telemetry_derived.cohort_daily_statistics_v1

Validated both staging tables. Reading one in-range activity_date per check gives complete cohort coverage (the query LEFT JOINs actives onto the full in-range cohort, so every cohort emits all its buckets at full size each day).

Within-staging structural gates — clean for both families:

  • No duplicate rows on the full dimension key now that install_source is part of it.
  • Grain strictly got finer — the install_source split happened, not a no-op.
  • Pre-2025 cohorts stay install_source = NULL at one row per dimension combo (no bleed-through, no fan-out).
  • Non-fenix rows are all install_source = NULL.

Live-prod comparisons — drift-tolerant (frozen snapshot gone; prod shredder-shrunk since build), both benign:

  • Cohort-size reconciliation: uniform +0.9% for telemetry (staging >= prod, no recent-cohort spike) — expected shredder gap.
  • Value existence: 112 telemetry orphan pairs, all 1-2-client buckets with real rare installer package names (shredder-emptied from prod, not invented).
  • Glean: exactly clean, 0 rows on every check.

Both families promote-safe.

Related Tickets & Documents

Reviewer, please follow this checklist

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR flips the status field from Initiate to Complete on the two cohort_daily_statistics backfill entries (telemetry_derived.cohort_daily_statistics_v2 and glean_telemetry_derived.cohort_daily_statistics_v1) added on 2026-07-06 for the install_source change from #9690. This is the documented transition (docs/cookbooks/backfilling_a_table.md) that triggers the staging→production swap after staging validation.

I reviewed both files against the backfill schema and validation rules and have no inline findings — the change is consistent with the standard workflow, and the accompanying validation notes in the description cover the staging/prod reconciliation.

@scholtzan

Copy link
Copy Markdown
Collaborator

Integration report

@kbammarito
kbammarito added this pull request to the merge queue Jul 21, 2026
Merged via the queue into main with commit 72f41d1 Jul 21, 2026
31 checks passed
@kbammarito
kbammarito deleted the DENG-11021-complete-two-backfills-tier-2 branch July 21, 2026 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants