Skip to content

Support dual-labeled metrics in structured_missing_columns#9699

Merged
BenWu merged 1 commit into
mainfrom
benwu/missing-columns-dual-labeled
Jul 15, 2026
Merged

Support dual-labeled metrics in structured_missing_columns#9699
BenWu merged 1 commit into
mainfrom
benwu/missing-columns-dual-labeled

Conversation

@BenWu

@BenWu BenWu commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Description

The join in the structured_missing_columns view doesn't account for dual-labeled so the columns are always marked as not existing in the schema.

Reviewer, please follow this checklist

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR extends the udf.remove_label_from_metric_path UDF to also match metrics.dual_labeled_ paths (in addition to metrics.labeled_), so dual-labeled metric columns are truncated to their first three path segments and can join against INFORMATION_SCHEMA.COLUMN_FIELD_PATHS in the structured_missing_columns view. A test case for a dual_labeled_counter path is included.

The logic is sound: both labeled and dual-labeled paths reduce to the first three segments regardless of label count, which matches the schema column name and the view's join. The prefix check generically covers all dual-labeled metric types. I have no findings to raise.

@scholtzan

Copy link
Copy Markdown
Collaborator

Integration report

@BenWu
BenWu enabled auto-merge July 15, 2026 19:13
@BenWu
BenWu added this pull request to the merge queue Jul 15, 2026
Merged via the queue into main with commit 2f7b4a7 Jul 15, 2026
31 checks passed
@BenWu
BenWu deleted the benwu/missing-columns-dual-labeled branch July 15, 2026 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants