Support dual-labeled metrics in structured_missing_columns#9699
Merged
Conversation
Contributor
There was a problem hiding this comment.
This PR extends the udf.remove_label_from_metric_path UDF to also match metrics.dual_labeled_ paths (in addition to metrics.labeled_), so dual-labeled metric columns are truncated to their first three path segments and can join against INFORMATION_SCHEMA.COLUMN_FIELD_PATHS in the structured_missing_columns view. A test case for a dual_labeled_counter path is included.
The logic is sound: both labeled and dual-labeled paths reduce to the first three segments regardless of label count, which matches the schema column name and the view's join. The prefix check generically covers all dual-labeled metric types. I have no findings to raise.
wwyc
approved these changes
Jul 15, 2026
Collaborator
Integration report
|
BenWu
enabled auto-merge
July 15, 2026 19:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The join in the structured_missing_columns view doesn't account for dual-labeled so the columns are always marked as not existing in the schema.
Reviewer, please follow this checklist