fix(styleguide): remove broken notifications route#596
Merged
VegasNative merged 1 commit intoMay 21, 2026
Merged
Conversation
The `/styleguide/notifications` route rendered a `notifications.html` template that does not exist, returning a 500 to anyone who hit it. The sibling `/styleguide/dashboard` route remains as the styleguide entry point. Also converts a floating string-statement between functions into a real `#` comment.
bheesham
approved these changes
May 21, 2026
bheesham
left a comment
bheesham
left a comment
Contributor
There was a problem hiding this comment.
🚀
Once merged, you should be able to deploy this in GCP.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Removes the unused
/styleguide/notificationsFlask route fromdashboard/app.py. The route rendered anotifications.htmltemplate that does not exist underdashboard/templates/, so any request to it raised a 500. While here, the floating string"""useful endpoint for debugging"""between functions is converted to a real#comment. It was a no-op statement, not a docstring.Why
Dead code. Nothing links to the route, and the template it referenced was never created. There is a
.notificationsCSS block indashboard/static/css/base.scsssuggesting this was started and abandoned, but there is no in-flight notifications feature to support. The sibling styleguide route/styleguide/dashboardis the actual styleguide entry point and is untouched.Blast radius
Minimal. The route was effectively unreachable: not linked from any template or navigation, and any direct visitor (e.g. a stale bookmark) was already hitting a 500. The only behavior change is that the response code becomes a 404 instead of a 500.
FakeUserremains in use via/styleguide/dashboard.Cross-repo coordination
None. No schema, contract, or
apps.ymlformat changes.Test plan
toxpasses locally (lint + types + tests + style).grepacross the repo confirms no other file referencesstyleguide_notificationsornotifications.html.Caveats
The
.notificationsCSS block remains instatic/css/base.scss. Cheap to leave; if a notifications feature ever comes back the CSS is there to build against, and if not it can be removed in a separate cleanup PR.