modify rate limit behavior on incoming funds

[Primata]

Goals:

• incoming rate limit of 100m
• remove the possibility of the rate limiting being offset

Changes behavior on incoming funds by removing release_rate_limit_capacity and adding try_consume_rate_limit_capacity on the Movement endpoint.

[ganymedio]

@Primata the change makes sense and appears to fit option 2 in the Slack discussion. New tests appear to be valid.

A couple thing to fix:

1. On main all tests pass with movement move test --dev

on this PR's branch we get the following failure:

Test failures:

Failures in 0x302814823::oft_using_move_oft_adapter_tests:

┌── test_send_rate_limit_netted_by_receive ──────
│ error[E11001]: test failure
│     ┌─ /Users/andygmove/Downloads/repos/layerzero-devtools/examples/oft-evm-move-adapters/sources/shared_oft/oft_impl_config.move:301:9
│     │
│ 294 │     public(friend) fun try_consume_rate_limit_capacity_at_time(
│     │                        --------------------------------------- In this function in 0x302814823::oft_impl_config
│     ·
│ 301 │         assert!(rate_limit.in_flight_on_last_update + amount <= rate_limit.limit, EEXCEEDED_RATE_LIMIT);
│     │         ^^^^^^ Test was not expected to error, but it aborted with code 4 originating in the module 0000000000000000000000000000000000000000000000000000000302814823::oft_impl_config rooted here
│ 
│ 
│ stack trace
│       oft_impl_config::try_consume_rate_limit_capacity(/Users/andygmove/Downloads/repos/layerzero-devtools/examples/oft-evm-move-adapters/sources/shared_oft/oft_impl_config.move:290)
│       move_oft_adapter::debit_fungible_asset(/Users/andygmove/Downloads/repos/layerzero-devtools/examples/oft-evm-move-adapters/sources/oft_implementation/move_oft_adapter.move:103)
│       oft::send_internal(/Users/andygmove/Downloads/repos/layerzero-devtools/examples/oft-evm-move-adapters/sources/shared_oft/oft.move:117)
│       oft::send_withdraw(/Users/andygmove/Downloads/repos/layerzero-devtools/examples/oft-evm-move-adapters/sources/shared_oft/oft.move:86-89)
│       oft_using_move_oft_adapter_tests::test_send_rate_limit_netted_by_receive(/Users/andygmove/Downloads/repos/layerzero-devtools/examples/oft-evm-move-adapters/tests/oft_using_move_oft_adapter_tests.move:320)
│ 
└──────────────────

Test result: FAILED. Total tests: 66; passed: 65; failed: 1
{
  "Error": "Move unit tests failed"
}

Please ensure all tests pass and logic is correct.

2. Clean up this Move warning:

warning: Unused value of parameter `src_eid`. Consider removing the parameter, or prefixing with an underscore (e.g., `_src_eid`), or binding to `_`
   ┌─ /Users/andygmove/Downloads/repos/layerzero-devtools/examples/oft-evm-move-adapters/sources/oft_implementation/move_oft_adapter.move:56:9
   │
56 │         src_eid: u32,
   │         ^^^^^^^

Thanks!

[apenzk]

if the changes match the propossal option 2 in PR 126, reference the PR to give context

movementlabsxyz/MIP#126

[Primata]

@Primata the change makes sense and appears to fit option 2 in the Slack discussion. New tests appear to be valid.

A couple thing to fix:

1. On main all tests pass with movement move test --dev

on this PR's branch we get the following failure:

Test failures:

Failures in 0x302814823::oft_using_move_oft_adapter_tests:

┌── test_send_rate_limit_netted_by_receive ──────
│ error[E11001]: test failure
│     ┌─ /Users/andygmove/Downloads/repos/layerzero-devtools/examples/oft-evm-move-adapters/sources/shared_oft/oft_impl_config.move:301:9
│     │
│ 294 │     public(friend) fun try_consume_rate_limit_capacity_at_time(
│     │                        --------------------------------------- In this function in 0x302814823::oft_impl_config
│     ·
│ 301 │         assert!(rate_limit.in_flight_on_last_update + amount <= rate_limit.limit, EEXCEEDED_RATE_LIMIT);
│     │         ^^^^^^ Test was not expected to error, but it aborted with code 4 originating in the module 0000000000000000000000000000000000000000000000000000000302814823::oft_impl_config rooted here
│ 
│ 
│ stack trace
│       oft_impl_config::try_consume_rate_limit_capacity(/Users/andygmove/Downloads/repos/layerzero-devtools/examples/oft-evm-move-adapters/sources/shared_oft/oft_impl_config.move:290)
│       move_oft_adapter::debit_fungible_asset(/Users/andygmove/Downloads/repos/layerzero-devtools/examples/oft-evm-move-adapters/sources/oft_implementation/move_oft_adapter.move:103)
│       oft::send_internal(/Users/andygmove/Downloads/repos/layerzero-devtools/examples/oft-evm-move-adapters/sources/shared_oft/oft.move:117)
│       oft::send_withdraw(/Users/andygmove/Downloads/repos/layerzero-devtools/examples/oft-evm-move-adapters/sources/shared_oft/oft.move:86-89)
│       oft_using_move_oft_adapter_tests::test_send_rate_limit_netted_by_receive(/Users/andygmove/Downloads/repos/layerzero-devtools/examples/oft-evm-move-adapters/tests/oft_using_move_oft_adapter_tests.move:320)
│ 
└──────────────────

Test result: FAILED. Total tests: 66; passed: 65; failed: 1
{
  "Error": "Move unit tests failed"
}

Please ensure all tests pass and logic is correct.

2. Clean up this Move warning:

warning: Unused value of parameter `src_eid`. Consider removing the parameter, or prefixing with an underscore (e.g., `_src_eid`), or binding to `_`
   ┌─ /Users/andygmove/Downloads/repos/layerzero-devtools/examples/oft-evm-move-adapters/sources/oft_implementation/move_oft_adapter.move:56:9
   │
56 │         src_eid: u32,
   │         ^^^^^^^

Thanks!

Oh okay, seems like we need to change previous tests, on it.

[ganymedio]

LGTM