Update CI config#83
Conversation
Codecov Report
@@ Coverage Diff @@
## master #83 +/- ##
==========================================
+ Coverage 72.75% 79.16% +6.42%
==========================================
Files 10 9 -1
Lines 554 499 -55
==========================================
- Hits 403 395 -8
+ Misses 151 104 -47
Continue to review full report at Codecov.
|
rhaschke
left a comment
There was a problem hiding this comment.
I took the chance to unify the CI config with that of the MoveIt main repo.
I also added a Noetic build. However, this fails. Please have a look!
|
|
||
| name: CI | ||
|
|
||
| on: [push, pull_request] |
There was a problem hiding this comment.
While updating this, do we want to add the pre-release test here too?
That test failure is because OpenCV 3.2, the default version for Ubuntu 18.04, has a buggy ArUco board pose detector. See discussion here, #5. I added a check to use the incorrect pose for 3.2 and the correct pose otherwise. |
rhaschke
left a comment
There was a problem hiding this comment.
From my point of view, this is ready to merge.
I'm not sure though, that we should consider wrong results for the unit tests against OpenCV 3.2. Alternatively, we could skip the test completely (in this case). However, then the remaining code isn't tested as well. Hence, I'm fine with the current solution as well.
Uh oh!
There was an error while loading. Please reload this page.