feat(cli): virtual_host S3 addressing (athena.toml)#83
Open
mostlymaxi wants to merge 1 commit into
Open
Conversation
mostlymaxi
changed the title
mostlymaxi
force-pushed
the
feat/s3-virtual-hosted
branch
from
c5237ed to
4ca0411
Compare
Add `[artifact_repository.s3] virtual_host` (bool, default false = path-style, what MinIO / most S3-compatible stores want). When true the CLI's object_store client uses virtual-hosted-style requests; resolved to a bool on S3Ref so publish / submit / emulate use one style for the binary tarball and load/save_artifact objects alike. CLI-side only for now: the in-pod Argo executor auto-detects until upstream Argo exposes the toggle on its S3 artifact. Regenerates the describe/ls metadata goldens (S3Ref's bool); emitted WorkflowTemplate YAML is unchanged.
mostlymaxi
changed the title
mostlymaxi
force-pushed
the
feat/s3-virtual-hosted
branch
from
4ca0411 to
216af80
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
virtual_hostedtoggle to[artifact_repository.s3]so the CLI can use virtual-hosted-style S3 addressing (https://<bucket>.<endpoint>/<key>) for providers that require it, instead of the default path-style.S3Repo.virtual_hosted: bool,#[serde(default)](false = path-style, backward-compatible; what MinIO and most S3-compatible stores want).S3Refand set at both construction sites from the configured repo:from_repo(publish / submit / emulate binary pull / doctor) andfrom_template'sto_ref(emulate'sload/save_artifact!object sync). So one addressing style applies to the binary tarball and artifacts alike.object_storeclient viawith_virtual_hosted_style_request.Scope / caveat (documented): CLI-side only for now. The in-pod Argo executor auto-detects addressing (minio-go), and Argo's S3 artifact doesn't expose the toggle, so this steers
cargo athena's own S3 client. The pod side follows once upstream Argo supports it.Regenerates the 3 describe/ls metadata JSON goldens (the metadata
S3Refgained the field, consistent with the already-serializedinsecure); the emitted WorkflowTemplate YAML is unchanged. Build / test / clippy / fmt / mdbook all green.