fix(macros): visit qualified fragment calls (foo::frag())#81
Merged
Conversation
BodyScan only recorded single-segment call paths, so a #[container] calling a #[fragment] via a qualified path (`foo::open_db()`) silently dropped the fragment's host! / secret! / artifact propagation. Record the last path segment of any call instead, matching how FragmentReg is keyed (by the fragment's bare ident). Unit test + a doc comment on the inherent name-matching limits (collision over-propagates, alias misses).
mostlymaxi
changed the title
mostlymaxi
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch release shipping the qualified-fragment-call fix.
Fix (
fix(macros)):BodyScan::visit_expr_callonly recorded single-segment call paths, so a#[container]/#[fragment]calling a#[fragment]via a qualified path (foo::open_db()) silently dropped the fragment'shost!/secret!/ artifact propagation. Now records the last path segment of any call (matching howFragmentRegis keyed). Unit test + a doc comment on the inherent name-matching limits.Release (
release: v0.6.1): bump the workspace version + the 4 inter-crate pins, regenerateCargo.lockand thecargo.athena/toolchainlabel in goldens /getting-started/emit.yaml, and bump theathena-publishaction pin inci.md.On merge, tagging
v0.6.1publishes to crates.io + the docs site. All gates green (39 goldens unchanged apart from the toolchain label, new macros unit test, clippy, fmt, mdbook).