Support for from __future__ import annotations#41
Open
mosquito wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves support for Python's
from __future__ import annotations(PEP 563/649) in theargclasslibrary by introducing a new utility function to robustly resolve type annotations, even when they are stringified. The changes ensure that type hints are correctly interpreted in modern Python versions and add comprehensive tests to verify this behavior.Enhanced annotation resolution:
resolve_annotationsfunction inargclass/utils.pythat usestyping.get_type_hints()to resolve stringified annotations, falling back to the legacymerge_annotationsif needed. This function is now used in bothargclass/parser.pyandargclass/store.pyto retrieve class annotations, replacing direct usage ofmerge_annotations. [1] [2] [3] [4] [5] [6]Testing for future annotations:
tests/test_future_annotations.pywith comprehensive test cases to ensureargclassworks correctly whenfrom __future__ import annotationsis enabled, covering basic types, optionals, literals, lists, enums, groups, subparsers, and secrets.