Repository navigation
Fix arginfo cache fallback for unhashable callables - #80
Merged
henri-hulski merged 1 commit intoOct 17, 2026
Merged
henri-hulski merged 1 commit into
henri-hulski merged 1 commit into
Conversation
henri-hulski
approved these changes
Oct 17, 2026
henri-hulski
left a comment
Member
There was a problem hiding this comment.
Looks good to me. Thank you for the contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #79.
arginfo()raisesTypeErrorfor ordinary unhashable callable instances (for example, dataclass functors) before reaching its existing bound-__call__cache fallback.arginfo.is_cached()fails on the same initial instance lookup.Treat an unhashable instance key as a reason to use that existing fallback. Keep the current cache keys and result reuse, and clarify the cache docstring. This also restores the documented
Noneresult for unhashable noncallables. Generic-function registration is outside this change.Four new regression cases cover the bound signature, defaults, keyword-only arguments, annotations, cache state and identity, and list/dict noncallables. All four fail before the fix.
Validation:
tox -e py311,py314,coverage,lint,docs,mypy,pyright,perf, including the 100% coverage gate, Ruff check/format, strict Sphinx HTML/doctests, and both type checkers' configured 3.11-3.15 targets.Disclosure: this contribution was investigated, implemented, tested, and reviewed autonomously with AI under the contributor's authorization. The independent review was also automated, not human approval.