feat(smitebot): accept config file support to doctor and build#131
Merged
Merged
Conversation
doctor and build
bb6084d to
db4578d
Compare
NishantBansal2003
suggested changes
Jun 24, 2026
NishantBansal2003
left a comment
Contributor
There was a problem hiding this comment.
I think that if we want to preserve the flags, they should override the corresponding fields in the config. This would make the config required while allowing flags to override specific values when provided. It simplifies the model, aligns with many established CLIs, and avoids the overhead of determining which options are required or mutually exclusive, WDYT?
db4578d to
5a2fe18
Compare
NishantBansal2003
suggested changes
Jun 25, 2026
5a2fe18 to
9421a2b
Compare
NishantBansal2003
approved these changes
Jun 25, 2026
712c24a to
4070d94
Compare
morehouse
requested changes
Jun 26, 2026
4070d94 to
56ddc0d
Compare
morehouse
requested changes
Jun 26, 2026
5d0f402 to
98ba31b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #116 , doctor and build now accept a campaign config file as a positional argument, replacing the need to pass paths manually via CLI flags.
CLI flags optionally override individual config values when provided:
Overview
smitebot build --target lnd --scenario encrypted_bytes) or with a config file where CLI flags override individual values--targetand--scenarioare required for build,--aflpp-pathis required for doctor, and--smite-dirdefaults to .Ref. #70