Skip to content

feat(quickcheck): add Arbitrary impl for Map to match HashMap #3585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bobzhang wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(quickcheck): add Arbitrary impl for Map to match HashMap #3585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1631f34
feat(quickcheck): add Arbitrary impl for Map to match HashMap
bobzhang May 13, 2026
2a5f679
fix(quickcheck): shrink size param when generating Map entries
bobzhang May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions quickcheck/arbitrary.mbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,3 +168,26 @@ pub impl[X : Arbitrary] Arbitrary for Array[X] with arbitrary(size, rs) {
let len = if size == 0 { 0 } else { rs.next_positive_int() % size }
Array::makei(len, x => X::arbitrary(x, rs))
}

///|
/// Returns a randomly generated map containing arbitrary key-value pairs.
///
/// Example:
///
/// ```mbt check
/// test {
/// let samples : Array[Map[Int, String]] = @quickcheck.samples(5)
/// inspect(samples.length(), content="5")
/// }
/// ```
pub impl[K : Arbitrary + Hash + Eq, V : Arbitrary] Arbitrary for Map[K, V] with arbitrary(
Comment on lines +172 to +183
size,
rs,
) {
let m : Map[K, V] = {}
let len = if size == 0 { 0 } else { rs.next_positive_int() % size }
for i in 0..<len {
m.set(K::arbitrary(i, rs), V::arbitrary(i, rs))
}
m
}
1 change: 1 addition & 0 deletions quickcheck/pkg.generated.mbti
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,5 @@ pub impl Arbitrary for Bytes
pub impl[X : Arbitrary] Arbitrary for Array[X]
pub impl[A : Arbitrary] Arbitrary for ArrayView[A]
pub impl[X : Arbitrary] Arbitrary for Iter[X]
pub impl[K : Arbitrary + Hash + Eq, V : Arbitrary] Arbitrary for Map[K, V]

Loading