Skip to content

Add make-and-blit array helpers#3564

Open
Yu-zh wants to merge 3 commits into
mainfrom
codex/make-and-blit-prototype
Open

Add make-and-blit array helpers#3564
Yu-zh wants to merge 3 commits into
mainfrom
codex/make-and-blit-prototype

Conversation

@Yu-zh

@Yu-zh Yu-zh commented May 9, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • add make-and-blit helpers backed by %fixedarray.make_with_blit and %fixedarray.make_with_init_blit
  • keep unsafe intrinsic wrappers private and expose only checked public helpers where needed
  • route Array/ArrayView/Bytes/FixedArray allocation-plus-blit paths through backend-specific helpers
  • add focused benchmarks for FixedArray copy, fixed-to-array conversion, Array/ArrayView concat, and resize growth

Commit structure

  • Add make-and-blit array helpers
  • Use make-and-blit helpers in array copies
  • Add make-and-blit array benchmarks

Validation

  • moon info
  • moon fmt
  • moon check --target native --deny-warn
  • moon check --target wasm --deny-warn
  • moon test immut/array --target native --release
  • moon test --target native --release
  • moon test --target wasm --release
  • git diff --check

Notes

  • rebased onto origin/main at 7a6bcacc4359e0c26f0959161e14a4b44872d16d
  • the previous native release CI crash in immut/array is not reproducible on the rebased branch; the focused package and full native release suite both pass locally

@coveralls

coveralls commented May 9, 2026

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 4486

Coverage decreased (-0.005%) to 94.084%

Details

  • Coverage decreased (-0.005%) from the base build.
  • Patch coverage: 2 uncovered changes across 2 files (94 of 96 lines covered, 97.92%).
  • No coverage regressions found.

Uncovered Changes

File Changed Covered %
builtin/fixedarray_block.mbt 6 5 83.33%
builtin/uninitialized_array.mbt 11 10 90.91%

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 15872
Covered Lines: 14933
Line Coverage: 94.08%
Coverage Strength: 207096.69 hits per line

💛 - Coveralls

@tonyfettes tonyfettes force-pushed the codex/make-and-blit-prototype branch from 3a84952 to 7dbcd52 Compare May 24, 2026 14:03
@Yu-zh Yu-zh changed the title Add make-with-blit array helpers Add make-and-blit array helpers May 24, 2026
@tonyfettes tonyfettes force-pushed the codex/make-and-blit-prototype branch from 7dbcd52 to 35eab3c Compare May 25, 2026 02:18
@tonyfettes tonyfettes force-pushed the codex/make-and-blit-prototype branch from 35eab3c to ee7db77 Compare May 25, 2026 03:24
@Yu-zh Yu-zh marked this pull request as ready for review May 25, 2026 03:30
@Yu-zh

Yu-zh commented May 25, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants