Bump runtime docs to rt4300#1456
Closed
0xlukem wants to merge 3 commits into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Moonriver runtime references in the docs to rt4300 and adds a Claude skill/script intended to automate future runtime bumps (variables, runtime-upgrades table, and associated test-suite updates).
Changes:
- Bump Moonriver
spec_versioninvariables.ymlfromruntime-4202toruntime-4300. - Update the runtime upgrades table row for
4300with the Moonriver upgrade block and a forum link. - Add a new
.claude/skills/runtime-bumpskill definition and a Python helper script to plan/apply/verify/create PRs for runtime bumps.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
variables.yml |
Updates Moonriver spec_version to runtime-4300. |
builders/build/runtime-upgrades.md |
Updates the 4300 row to include a forum link and Moonriver’s upgrade block. |
.claude/skills/runtime-bump/SKILL.md |
Documents the intended runtime bump workflow for the skill. |
.claude/skills/runtime-bump/scripts/runtime-bump |
Adds an automation script for planning/applying/verifying runtime bumps and creating PRs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+280
to
+284
| if not config.subscan_api_key and not has_complete_overrides(config): | ||
| raise RuntimeBumpError( | ||
| "SUBSCAN_API_KEY is required for live detection. Set it or provide " | ||
| "--runtime and --upgrade-block overrides for every network that changed." | ||
| ) |
| network = network.strip() | ||
| if network not in NETWORKS: | ||
| raise RuntimeBumpError(f"unknown network in {flag}: {network}") | ||
| parsed[network] = int(number) |
| if "=" not in value: | ||
| raise RuntimeBumpError(f"--forum-url expects VERSION=URL, got {value!r}") | ||
| version, url = value.split("=", 1) | ||
| parsed[int(version)] = url.strip() |
Comment on lines
+105
to
+109
| out = ( | ||
| validate_plan_output_path(Path(args.plan_out), config) | ||
| if args.plan_out | ||
| else default_plan_path(config) | ||
| ) |
Comment on lines
+1005
to
+1012
| def verify_plan(config: RuntimeConfig, plan: dict[str, Any]) -> None: | ||
| print("Verification report") | ||
| verify_git_diff(config.docs_repo, "docs") | ||
| test_repo = config.test_suite_repo or Path(plan.get("test_suite_repo") or "") | ||
| if test_repo and test_repo.exists(): | ||
| verify_git_diff(test_repo, "test-suite") | ||
| else: | ||
| print("- test-suite: checkout not found; skipping git diff") |
Comment on lines
+1147
to
+1150
| run_cmd(["git", "commit", "-m", title], repo) | ||
| head = push_branch(repo, target_repo, branch) | ||
| run_cmd(["gh", "pr", "create", "--repo", target_repo, "--base", "master", "--head", head, "--title", title, "--body", body], repo) | ||
|
|
| out.write_text(json.dumps(plan, indent=2, sort_keys=True) + "\n", encoding="utf-8") | ||
| print(f"Full plan written to {out}") | ||
| else: | ||
| print("Pass --plan-out <path> to save the full plan JSON.") |
Comment on lines
+223
to
+224
| skill_dir = Path(__file__).resolve().parents[1] | ||
| docs_repo = skill_dir.parents[2] |
Contributor
Author
|
Closing this one in favor of #1457, since this was a test for the new claude skill I'm working on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated runtime bump for docs.
Updated networks: moonriver runtime-4300
Review items: