GODRIVER-3954: Implement ServerErrorInterface for ClientBulkWriteException - #2606
Open
ayesha-ilm wants to merge 6 commits into
Open
ayesha-ilm wants to merge 6 commits into
ayesha-ilm wants to merge 6 commits into
Conversation
Contributor
API Change Report./v2/mongocompatible changesClientBulkWriteException.HasErrorCode: added |
qingyang-hu
reviewed
Sep 18, 2026
qingyang-hu
reviewed
Sep 18, 2026
qingyang-hu
requested changes
Sep 18, 2026
Co-authored-by: Preston Vasquez <prestonvasquez@icloud.com>
…o-driver into GODRIVER-3954
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GODRIVER-3954
Summary
ClientBulkWriteException now implements the full ServerError interface.
Background & Motivation
ClientBulkWriteException did not implement the full ServerError interface. As a result, errors.As(err, &serverErr) returns false for a client bulk write error, and the idiomatic server-error detection path.
What I have done
added missing interface functions:
to ClientBulkWriteException
Test Plans
Just repurposed some of the tests already in TestServerErrorr from other exceptions to apply to ClientBulkWriteException