This repository was archived by the owner on May 13, 2026. It is now read-only.
chore: bump eslint-config-moneyforward from 1.0.0 to 2.0.0#280
Merged
horaotoko merged 2 commits intoJan 18, 2023
Merged
Conversation
Bumps [eslint-config-moneyforward](https://github.com/moneyforward/eslint-config-moneyforward) from 1.0.0 to 2.0.0. - [Release notes](https://github.com/moneyforward/eslint-config-moneyforward/releases) - [Commits](moneyforward/frontend-tools@1.0.0...2.0.0) --- updated-dependencies: - dependency-name: eslint-config-moneyforward dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
requested review from
horaotoko
and removed request for
a team
dependabot
Bot
added
the
dependencies
horaotoko
reviewed
Jan 18, 2023
| "@types/styled-components": "^5.1.26", | ||
| "@typescript-eslint/eslint-plugin": "^4.33.0", | ||
| "@typescript-eslint/parser": "^4.33.0", | ||
| "@typescript-eslint/eslint-plugin": "^5.48.2", |
Member
There was a problem hiding this comment.
These @typescript-eslint are conflicted with eslint-config-moneyforward
horaotoko
reviewed
Jan 18, 2023
| "eslint": "^7.32.0", | ||
| "eslint-config-moneyforward": "^1.0.0", | ||
| "eslint-config-moneyforward": "^2.0.0", | ||
| "eslint-plugin-jest": "^27.2.1", |
Member
There was a problem hiding this comment.
This eslint-plugin-jest is required for eslint-config-moneyforward
horaotoko
reviewed
Jan 18, 2023
| fireEvent.click(screen.getByRole('button', { name: '閉じる' })); | ||
| }); | ||
|
|
||
| it('props.onClickClose is called', () => { |
Member
There was a problem hiding this comment.
This test was redundant.
I bundled together in a case.
Member
|
@kimromi |
kimromi
approved these changes
Jan 18, 2023
| render(<Backdrop open onClick={onClick} data-testid="testid" />); | ||
| fireEvent.click(screen.getByTestId('testid')); | ||
| expect(onClick).toBeCalledTimes(1); | ||
| expect(onClick).toHaveBeenCalledTimes(1); |
Contributor
There was a problem hiding this comment.
horaotoko
deleted the
dependabot/npm_and_yarn/eslint-config-moneyforward-2.0.0
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps eslint-config-moneyforward from 1.0.0 to 2.0.0.
Release notes
Sourced from eslint-config-moneyforward's releases.
Commits
baffed6Release 2.0.02d682ecUpdate@typescript-eslint/parserrequirement from ^5.48.1 to ^5.48.2ee4429cUpdate@typescript-eslint/eslint-pluginrequirementbaf3290Update eslint-plugin-react requirement from ^7.32.0 to ^7.32.1c3252efUpdate prettier requirement from ^2.8.2 to ^2.8.319cfc8eUpdate eslint requirement from ^8.31.0 to ^8.32.0c7cab27Update eslint-plugin-react requirement from ^7.31.11 to ^7.32.00e4dc59Update eslint-plugin-testing-library requirement from ^4.6.0 || ^5.0.0 to ^5.9.15fd34b5Update eslint-plugin-jest requirement from ^27.2.0 to ^27.2.1032c00bUpdate eslint-plugin-react-hooks requirement from ^4.2.0 to ^4.6.0Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)