Fix get_open_modules to return correct module names for bound open statements#3
Open
ghaaj wants to merge 2 commits into
Open
Fix get_open_modules to return correct module names for bound open statements#3ghaaj wants to merge 2 commits into
get_open_modules to return correct module names for bound open statements#3ghaaj wants to merge 2 commits into
Conversation
Author
|
先例に倣って日本語で書きましたが、英語のほうが望ましいでしょうか…？ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_open_modulesがbind_stmtのソーステキストをそのまま Vector に加えて返していたためにモジュール名が解決できなかった問題を修正しました。以下のようなケースで、
font-latin-boldのような識別子から定義にジャンプできるようになっているはずです。この変更に関連して if-let chains を使えるようにするため edition を 2024 に更新しました。2024 では
std::env::set_varが新たに unsafe に指定されたため、ブロックに包んでいます。