Repository navigation
Identify OAuth token requests with Mollie client headers - #396
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #296.
OAuth token exchange, refresh, and revocation currently use requests-oauthlib's default identification headers, unlike the normal API requests. Set
User-AgentandX-Mollie-Client-Infoon the OAuth session so token requests carry the same SDK information. Keep the session user-agent updated when an application changes a component after setup.The parametrized regression covers authorization-code exchange, explicit refresh, automatic refresh, and revocation, both before and after updating an application component. It checks the actual outgoing headers and preserves OAuth's form content type.
Validation on Windows:
flake8passes;mypy --config mypy.ini mollie/passes (57 source files).git diff --checkpasses.No live OAuth credentials/payment requests were used. Linux, Python 3.11/3.12, and Safety scanning were not run locally.
Prepared with Codex assistance.