REFER expectations by sfgeorge · Pull Request #15 · mojolingo/sippy_cup

sfgeorge · 2013-09-03T07:34:39Z

Add support for expecting and accepting a REFER message.

bklang · 2013-09-03T20:26:20Z

Ok, to answer my own question, it looks like you're using when responding with a 200 to a REFER, in which case you do not want rrs.

Also, would you mind adding some tests to cover this new functionality?

bklang · 2013-09-12T20:36:23Z

@sfgeorge, when you get a chance: In addition to the tests, I know that @vindir identified some changes to the REFER flow that need to be made in order for it to work successfully. Would the two of you get together and update this PR to include the corrected messages?

bklang · 2013-09-17T16:29:11Z

@sfgeorge If you would still like this merged, would you update it so it can be merged? Also, I believe @vindir had a functional change to make to the generated SIPp instructions, in light of our testing with your infrastructure.

benlangfeld · 2013-09-17T16:30:17Z

This should probably wait until #34 is merged in a couple of hours.

benlangfeld · 2013-09-17T18:43:03Z

Ok, #34 was merged. Please ensure this PR complies with the standards of testing and documentation now in effect on Scenario.

leifmadsen · 2013-11-19T19:22:58Z

Pssst... just pinging the project :)

bklang · 2013-11-20T16:55:55Z

I think there are two outstanding items on this:

Fix the generated XML for REFER scenarios (this one contains a bug if I recall correctly)
Add/update specs to handle the new methods

sfgeorge · 2013-11-20T17:07:10Z

Agreed! Regarding point 1, @vindir Can you share any insight you have with problems you had with the REFER dialogue I constructed?

bklang · 2014-10-07T02:45:59Z

@sfgeorge By any chance, do you have SIPp scenarios containing a REFER that you can compare to this PR? Can you either confirm that the REFER this code generates is correct, or suggest a change?

sfgeorge · 2014-10-09T14:04:43Z

Howdy! Yes, I can sure give an example exchange from Asterisk 1.8 that matches this exchange. Would you recommend any other systems to compare against?

bklang · 2014-10-09T14:13:43Z

I'll take whatever examples you've got, but Asterisk 1.8 is a good start.

benlangfeld · 2015-03-16T18:21:16Z

@sfgeorge Do you have those examples? Might you be able to rebase this PR so we can get it in to the next version?

sfgeorge · 2015-03-17T16:40:27Z

Eek, sorry for the delay. Happy Holidays, Happy New Year and Happy Saint Patrick's Day! 🍀 😄

I can rebase this weekend if that works.

What's the best format for an example? I can send you pcap if that would suffice.

benlangfeld · 2015-03-17T17:07:07Z

A pcap would be fine :)

And upgrade test suite to cover Ruby 2.2 & 2.3

…acket

Install pcap spec dependency

One test was already failing because it was somehow half-way between the two syntaxes!

This was broken by 893865f.

It is not always necessary and it looks like the next version may not need it at all.

Allow SIPp to be launched without sudo

set event end flag for dtmf digits

Nokogiri update

pk1057 · 2018-03-07T20:50:09Z

Hello,
i'm interested to get this feature up and running.
Does an scripting example exist to save me some time during testing ?

sfgeorge · 2018-03-07T20:58:21Z

Hi @pk1057 my foul, I will try to update this PR and share for your and everyone's benefit. Thank you for the reminder! 🎗

pk1057 · 2018-03-09T08:13:16Z

Hi @sfgeorge, these are great news and i'm eagerly looking forward.
If i can help don't hesitate to contact me.

Loading of the various classes was just a bit broken. 1.1.13 works fine and it supports Ruby 2.4.

PacketFu 1.1.12 didn't really drop PacketFu::UDPPacket

Fix non-writing of PCAP file when media is empty

…packets

Robust dtmf packets

[CI] Add CI builds against C-Ruby 2.4, 2.5 and 2.6

Bump Nokogiri dep to address security concern

sfgeorge mentioned this pull request Sep 3, 2013

Various tweaks #14

Merged

ghost assigned vindir Nov 20, 2013

sfgeorge unassigned vindir Oct 7, 2014

benlangfeld and others added 13 commits July 13, 2015 19:18

Merge branch 'release/0.7.2' into develop

a509734

Happy New Year

4db0184

Install pcap spec dependency

5d159a2

And upgrade test suite to cover Ruby 2.2 & 2.3

Drop support for Ruby < 2.3

36ed072

Upgrade rspec to for modernization

ee68ead

PacketFu 1.1.12 introduces a breaking change, removing PacketFu::UDPP…

c7bb9ec

…acket

Merge pull request mojolingo#90 from mojolingo/feature/travis_fixes

5b182f4

Install pcap spec dependency

Now require Ruby 2.3

6b5a5c9

Use transpec to convert to new RSpec expect syntax

491c0b7

One test was already failing because it was somehow half-way between the two syntaxes!

Fix non-writing of PCAP file when media is empty

dedfc0d

This was broken by 893865f.

Allow SIPp to be launched without sudo

fe49676

It is not always necessary and it looks like the next version may not need it at all.

Merge pull request mojolingo#97 from yakara-ltd/feature/nosudo

41efd37

Allow SIPp to be launched without sudo

set event end flag for dtmf digits

a797d1d

bklang and others added 4 commits December 26, 2017 10:12

Merge pull request mojolingo#99 from aukeman/dtmf-end-flag

fffcf0c

set event end flag for dtmf digits

Merge branch 'master' into develop

5f6d569

Update Nokogiri for security issue

6c6288e

Merge pull request mojolingo#100 from mojolingo/feature/deps_update

e8877b1

Nokogiri update

chewi and others added 16 commits March 16, 2018 17:16

PacketFu 1.1.12 didn't really drop PacketFu::UDPPacket

b04c7af

Loading of the various classes was just a bit broken. 1.1.13 works fine and it supports Ruby 2.4.

Merge pull request mojolingo#101 from yakara-ltd/packetfu

977ccea

PacketFu 1.1.12 didn't really drop PacketFu::UDPPacket

Merge pull request mojolingo#83 from yakara-ltd/bugfix/nomedia

eb34f53

Fix non-writing of PCAP file when media is empty

generate more robust DTMF events

d1b52ab

Merge branch 'develop' of github.com:VHTx/sippy_cup into robust-dtmf-…

1ced85c

…packets

Merge pull request mojolingo#103 from VHTx/robust-dtmf-packets

f778cdf

Robust dtmf packets

[CI] Add CI builds against C-Ruby 2.4, 2.5 and 2.6

4169655

[CI] Add ruby-2.5.3

e35b29a

[CI] Use Xenial build and rubies that are on it

c22f47b

[SPEC] Make spec a bit more lax for ruby-2.5

d29188f

Merge pull request mojolingo#104 from sfgeorge/patch-1

2dad177

[CI] Add CI builds against C-Ruby 2.4, 2.5 and 2.6

Bump Nokogiri dep to address security concern

6ff6747

Merge pull request mojolingo#105 from mojolingo/feature/nokogiri_upgrade

a1a1936

Bump Nokogiri dep to address security concern

Add support for receiving REFERs

cfdf674

[DOC] Categorize supported commands

04c7f24

[DOC] Categorize transfer/REFER commands separately

3dba3c7

sfgeorge force-pushed the feature/wait_for_refer branch from f25169c to 3dba3c7 Compare December 15, 2019 19:08

Uh oh!

Conversation

sfgeorge commented Sep 3, 2013

Uh oh!

bklang commented Sep 3, 2013

Uh oh!

bklang commented Sep 12, 2013

Uh oh!

bklang commented Sep 17, 2013

Uh oh!

benlangfeld commented Sep 17, 2013

Uh oh!

benlangfeld commented Sep 17, 2013

Uh oh!

leifmadsen commented Nov 19, 2013

Uh oh!

bklang commented Nov 20, 2013

Uh oh!

sfgeorge commented Nov 20, 2013

Uh oh!

bklang commented Oct 7, 2014

Uh oh!

sfgeorge commented Oct 9, 2014

Uh oh!

bklang commented Oct 9, 2014

Uh oh!

benlangfeld commented Mar 16, 2015

Uh oh!

sfgeorge commented Mar 17, 2015

Uh oh!

benlangfeld commented Mar 17, 2015

Uh oh!

pk1057 commented Mar 7, 2018

Uh oh!

sfgeorge commented Mar 7, 2018

Uh oh!

pk1057 commented Mar 9, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants