Skip to content

Fix cifriendly-profile-bug#126

Draft
ciis0 wants to merge 1 commit into
mojohaus:masterfrom
ciis0:cifriendly-profile-bug
Draft

Fix cifriendly-profile-bug#126
ciis0 wants to merge 1 commit into
mojohaus:masterfrom
ciis0:cifriendly-profile-bug

Conversation

@ciis0

@ciis0 ciis0 commented Jan 17, 2020

Copy link
Copy Markdown

Supersedes #114
Fixes #103

@ciis0

ciis0 commented Jan 23, 2020

Copy link
Copy Markdown
Author

So, I getLog().info(...)-debugged some things and found that the issue arises in the following line:

Model originalModel = this.project.getOriginalModel().clone();

This "original model" already has some properties interpolated, for example ${basedir}, which is the original error that arose in the context I experienced this bug.

Therefore #getOriginalModel() does not seem to be suited for CI-friendly interpolation.

For cifriendlies, the following line might needs to work on a raw POM (FlattenMojo#getRawPom of #114), not originalModel:

return this.modelCiFriendlyInterpolator.interpolateModel( originalModel, this.project.getModel().getProjectDirectory(),
buildingRequest, problems );

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

resolveCiFriendliesOnly interpolates more than just version and pom elements

2 participants