feat: Added a new GCBM status endpoint#180
Open
SanjaySinghRajpoot wants to merge 8 commits into
Open
Conversation
SanjaySinghRajpoot
force-pushed
the
statusApi
branch
from
046c8d5 to
bf8899b
Compare
HarshCasper
requested changes
Oct 10, 2022
HarshCasper
left a comment
HarshCasper
left a comment
Member
There was a problem hiding this comment.
The tests continue to fail. Can you validate once again?
Contributor
Author
|
The test case is failing for some other endpoint of GCBM simulation. Earlier I added some test cases for this endpoint they were not working as expected so I had to remove them. I am working on adding some new test cases for this endpoint. |
Contributor
|
@SanjaySinghRajpoot @HarshCasper - what is the status of this PR? |
Contributor
Author
|
The test cases are failing for this some other endpoint in this PR. In this PR we are trying to get the status of GCBM simulation, using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
A new endpoint is created called
/gcbm/status. This endpoint will return the status of the running GCBM simulation and the logs generated insimulation.txt. This endpoint will be called by the FLINT-UI to get the latest status of the GCBM simulation. In this manner, the user will be able to check if everything is working correctly or if there is any error. If the simulation is not running a400status will be returned to the user.Fixes #179
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
It has been tested on a local host. The above image giving a error message as no simulation is running.