-
Notifications
You must be signed in to change notification settings - Fork 0
Use S3 to upload feedback images #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hugozap
wants to merge
1
commit into
main
Choose a base branch
from
update-s3-feedback-image-upload
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,3 +6,4 @@ node_modules | |
| # CDK asset staging directory | ||
| .cdk.staging | ||
| cdk.out | ||
| .DS_Store | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| /* Lambda that returns a signed URL for uploading an image to S3. | ||
| * The frontend will use this URL to upload the image directly to S3. | ||
| * and store it with the feedback form data. | ||
| */ | ||
|
|
||
| import { APIGatewayProxyHandler, APIGatewayProxyEvent } from "aws-lambda"; | ||
| import { S3 } from "aws-sdk"; | ||
| import * as uuid from "uuid"; | ||
|
|
||
| export const handler: APIGatewayProxyHandler = async ( | ||
| event: APIGatewayProxyEvent | ||
| ) => { | ||
| const s3 = new S3(); | ||
| const params = { | ||
| Bucket: process.env.BUCKET_NAME!, | ||
| Key: `${uuid.v4()}.jpeg`, | ||
| ContentType: "image/jpeg", | ||
| }; | ||
|
|
||
| const url = await s3.getSignedUrlPromise("putObject", params); | ||
|
|
||
| return { | ||
| statusCode: 200, | ||
| body: JSON.stringify({ url }), | ||
| }; | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1,13 @@ | ||
| /* create cdk resources for feedback feature (lambda and dynamodb table) */ | ||
|
|
||
| import { Table, TableProps } from "aws-cdk-lib/aws-dynamodb"; | ||
| import { | ||
| Function, | ||
| FunctionProps, | ||
| Runtime, | ||
| Code, | ||
| } from "aws-cdk-lib/aws-lambda"; | ||
| import { Function, FunctionProps, Runtime, Code } from "aws-cdk-lib/aws-lambda"; | ||
| import { Construct } from "constructs"; | ||
| import { getNamespace } from "../util"; | ||
| import { AttributeType } from "aws-cdk-lib/aws-dynamodb"; | ||
|
|
||
| import { Bucket, BucketAccessControl, HttpMethods } from "aws-cdk-lib/aws-s3"; | ||
|
|
||
|
|
||
| export function getFeedbackTable(scope: Construct, props?: TableProps): Table { | ||
| return new Table(scope, `FeedbackTable${getNamespace()}`, { | ||
| partitionKey: { | ||
|
|
@@ -26,7 +20,7 @@ export function getFeedbackTable(scope: Construct, props?: TableProps): Table { | |
|
|
||
| export function getLambdaApiSaveFeedback( | ||
| scope: Construct, | ||
| //optional | ||
| //optional | ||
| props?: Partial<FunctionProps> | ||
| ): Function { | ||
| return new Function(scope, `LambdaApiSaveFeedback${getNamespace()}`, { | ||
|
|
@@ -36,3 +30,28 @@ export function getLambdaApiSaveFeedback( | |
| ...props, | ||
| }); | ||
| } | ||
|
|
||
| export function getUploadImageLambda( | ||
| scope: Construct, | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we need any test coverage? |
||
| props?: Partial<FunctionProps> | ||
| ): Function { | ||
| return new Function(scope, `LambdaUploadImage${getNamespace()}`, { | ||
| runtime: Runtime.NODEJS_14_X, | ||
| handler: "uploadImage.handler", | ||
| code: Code.fromAsset("lambdas/getUploadImageSignedUrl"), | ||
| ...props, | ||
| }); | ||
| } | ||
|
|
||
| export function getFeedbackImageBucket(scope: Construct): Bucket { | ||
| return new Bucket(scope, `FeedbackImageBucket${getNamespace()}`, { | ||
| accessControl: BucketAccessControl.PRIVATE, | ||
| cors: [ | ||
| { | ||
| allowedOrigins: ["*"], | ||
| allowedMethods: [HttpMethods.GET, HttpMethods.PUT, HttpMethods.HEAD], | ||
| }, | ||
| ], | ||
| bucketName: `feedback-image-${getNamespace()}`, | ||
| }); | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we confirmed about the file type will be always
jpeg?