Skip to content

fix: annotate context managers with Generator for ty 0.0.85 - #69

Merged
lesnik512 merged 1 commit into
mainfrom
fix/ty-0-0-85
Oct 7, 2026
Merged

lesnik512 merged 1 commit into
mainfrom
fix/ty-0-0-85

Conversation

@lesnik512

Copy link
Copy Markdown
Member

Summary

Closes #68

ty 0.0.85 bundles a typeshed that deprecates the contextmanager overload for functions annotated -> Iterator[T]. ty check reported this as two warnings in modern_di_typer/main.py, which failed the scheduled lint-ci run.

The new annotations come from collections.abc. typing.Generator needs all three type arguments before Python 3.13, so typing.Generator[Container] would fail at runtime on 3.11 and 3.12.

Changes

  • _build_command_container and action_scope now return collections.abc.Generator[Container] instead of typing.Iterator[Container].

Checklist

  • Lint and format pass (ruff)
  • Type check passes (ty)
  • Tests pass and new behavior is covered
  • Build succeeds (uv build) if packaging or build config changed
  • Repo metadata stays consistent across the three surfaces (GitHub description, pyproject description, profile blurb) if this touches packaging

@lesnik512
lesnik512 merged commit d241063 into main Oct 7, 2026
12 checks passed
@lesnik512
lesnik512 deleted the fix/ty-0-0-85 branch October 7, 2026 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scheduled dependency check failed

1 participant