Repository navigation
fix: ruff 0.17 ICN001 and batch_bodies setter (ty 0.0.86) - #208
Merged
Merged
Conversation
…ter for ty 0.0.86
Benchmark gate✅ gate passed
Gated (fails the build): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #207.
The scheduled dependency check picked up ruff 0.17.0 and ty 0.0.86, and both fail on main.
ICN001fordatetime, soimport datetime as _dtis renamed todtin 14 files. This is the ruff autofix. Nothing else in the codebase is nameddt, so the rename can't shadow anything.OutboxPublishCommand.batch_bodiesoverrides upstream's writableBatchPublishCommand.batch_bodieswith a read-only property. That is a real break:cmd.batch_bodies = ...raisedAttributeError. The new setter matches upstream: the first item goes tobodyand the rest toextra_bodies. An empty sequence setsbody=None, so the getter returns(None,), consistent with this class keepingNonebodies.The new test
test_publish_command_batch_bodies_is_assignablefailed before the fix. Locally,just lint-ciis clean and the full suite passes against Postgres 17 (626 passed).