feat(viewer): homeView host flag — don't auto-select a session when the host owns Home#174
Draft
benvinegar wants to merge 1 commit into
Draft
feat(viewer): homeView host flag — don't auto-select a session when the host owns Home#174benvinegar wants to merge 1 commit into
benvinegar wants to merge 1 commit into
Conversation
…he host owns Home When a host owns its own session-less landing (e.g. sideshow cloud's Home feed), auto-selecting a session on boot leaves it highlighted in the sidebar behind the host's landing, and navigating back to the session-less route never clears it (applyRoute ignores a null route). Add an opt-in `homeView` flag to SideshowHost: when set, the engine honors a deep-linked route session but otherwise stays session-less on boot (no selection, no highlight), and clears its selection when the route becomes session-less. Self-hosted leaves the flag unset and is unchanged (auto-selects the latest on boot; deselects via the wordmark goHome). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an opt-in
homeViewflag to the embedSideshowHostcontract.When an embedder owns its own session-less landing (e.g. sideshow cloud's new Home feed), the engine auto-selecting a session on boot leaves that session highlighted in the sidebar behind the host's landing, and navigating back to the session-less route never clears it (
applyRoutedeliberately ignores a null route).With
homeView: true, the engine:route.sessionIdbut otherwise stays session-less on boot (no selection, nothing highlighted);Self-hosted leaves the flag unset and is unchanged — it still auto-selects the latest session on boot and deselects explicitly via the wordmark
goHome(). Covered bye2e/embed-home-view.spec.ts(flag on → nothing selected; flag off → auto-selects). Changeset (minor).🤖 Generated with Claude Code